GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-106193: Rename and fix duplicated tests in `test_monitoring` (GH-109139) by hugovk · Pull Request #110897 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Oct 15, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit ea530f2)

  • Issue: test_monitoring has duplicated tests #106193

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
[3.12] pythongh-106193: Rename and fix duplicated tests in `test_moni…
15ea3d5 
…toring` (pythonGH-109139)

(cherry picked from commit ea530f2)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Oct 15, 2023
test_monitoring has duplicated tests #106193
Closed
@bedevere-app bedevere-app Bot added awaiting core review tests Tests in the Lib/test dir labels Oct 15, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 15, 2023
gh-106193: Rename and fix duplicated tests in test_monitoring #109139
Merged
@bedevere-app bedevere-app Bot added the skip news label Oct 15, 2023
AlexWaygood
AlexWaygood approved these changes Oct 15, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 15, 2023
@hugovk
hugovk enabled auto-merge (squash) October 15, 2023 16:44
This was referenced Oct 15, 2023
Lint: Include test_monitoring.py for Ruff #110898
Merged
[3.12] Lint: Include test_monitoring.py for Ruff (GH-110898) #110899
Merged
@hugovk
hugovk merged commit 9c39149 into python:3.12 Oct 15, 2023
@hugovk
hugovk deleted the backport-ea530f2-3.12 branch October 15, 2023 17:32
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.