GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — `test_monitoring` has duplicated tests · Issue #106193 · python/cpython

test_monitoring has duplicated tests #106193

New issue
Copy link
New issue
Copy link
Closed
#109139
Closed
test_monitoring has duplicated tests#106193
#109139
Copy link
Assignees
sobolevn
Labels
3.12only security fixesonly security fixes3.13only security fixesonly security fixestestsTests in the Lib/test dirTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Description

@sobolevn
sobolevn
opened on Jun 28, 2023
Issue body actions

Based on python/core-workflow#505 by @hugovk

Lib/test/test_monitoring.py:973:5: F811 redefinition of unused 'test_line_then_instruction' from line 950
Lib/test/test_monitoring.py:978:5: F811 redefinition of unused 'test_instruction_then_line' from line 955

Before rename: Ran 49 tests in 0.014s
After rename:

======================================================================
ERROR: test_instruction_then_line (test.test_monitoring.TestInstallIncrementallly.test_instruction_then_line)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/sobolev/Desktop/cpython/Lib/test/test_monitoring.py", line 956, in test_instruction_then_line
    recorders = [ InstructionRecorder, LineRecorderLowNoise ]
                                       ^^^^^^^^^^^^^^^^^^^^
NameError: name 'LineRecorderLowNoise' is not defined

======================================================================
ERROR: test_line_then_instruction (test.test_monitoring.TestInstallIncrementallly.test_line_then_instruction)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/sobolev/Desktop/cpython/Lib/test/test_monitoring.py", line 953, in test_line_then_instruction
    recorders = recorders, must_include = self.EXPECTED_LI)
                                          ^^^^^^^^^^^^^^^^
AttributeError: 'TestInstallIncrementallly' object has no attribute 'EXPECTED_LI'

----------------------------------------------------------------------
Ran 51 tests in 0.045s

FAILED (errors=2)
test test_monitoring failed
test_monitoring failed (2 errors)

== Tests result: FAILURE ==

1 test failed:
    test_monitoring

Total duration: 94 ms
Tests result: FAILURE

Based on the missing runtime parts in these tests, we can just remove the first two ones, I guess.

Both of these tests were introduced in 411b169 by @markshannon

Linked PRs

  • gh-106193: Rename and fix duplicated tests in test_monitoring #109139
  • [3.12] gh-106193: Rename and fix duplicated tests in test_monitoring (GH-109139) #110897

Activity

  1. sobolevn
    added
    type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
    testsTests in the Lib/test dirTests in the Lib/test dir
    on Jun 28, 2023
  2. sobolevn
    self-assigned this
    on Jun 28, 2023
  3. sobolevn commented on Jun 28, 2023

    @sobolevn
    sobolevn
    on Jun 28, 2023
    MemberAuthor
    More actions

    No, they cannot be just deleted, because they test different things.

  4. sobolevn commented on Jun 29, 2023

    @sobolevn
    sobolevn
    on Jun 29, 2023
    MemberAuthor
    More actions

    Introduced in b32a075#diff-15fb0cb29709c04c449bacd69e4ab2208372424d8390c26258eb83b2363c3cf1

    Looks like it never had parts that are missing right now.

  5. hugovk
    added
    3.12only security fixesonly security fixes
    3.13only security fixesonly security fixes
    on Sep 8, 2023
  6. hugovk commented on Sep 8, 2023

    @hugovk
    hugovk
    on Sep 8, 2023
    Member
    More actions

    Please see PR #109139.

  7. markshannon
    closed this as completedin #109139on Oct 12, 2023
  8. markshannon
    added a commit that references this issue on Oct 12, 2023

    gh-106193: Rename and fix duplicated tests in `test_monitoring` (GH-1…

    ea530f2
  9. hugovk
    added 2 commits that reference this issue on Oct 15, 2023

    [3.12] pythongh-106193: Rename and fix duplicated tests in `test_moni…

    15ea3d5

    [3.12] gh-106193: Rename and fix duplicated tests in `test_monitoring` (

    9c39149
  10. Glyphack
    added a commit that references this issue on Sep 2, 2024

    pythongh-106193: Rename and fix duplicated tests in `test_monitoring` (…

    ace4b62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

  • @sobolevn
    sobolevn

Labels

3.12only security fixesonly security fixes3.13only security fixesonly security fixestestsTests in the Lib/test dirTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    You are visitor 01402503 — GeezerVison does not store the pages you look up.
    Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.