GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-85283: Fix _ctypes_test build on Windows in release mode by vstinner · Pull Request #111005 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 17, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Define Py_BUILD_CORE to not attempt to link the extension to python3.lib (which fails).

  • Issue: [C API] Convert a few stdlib extensions to the limited C API (PEP 384) #85283

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the skip news label Oct 17, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 17, 2023
[C API] Convert a few stdlib extensions to the limited C API (PEP 384) #85283
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 17, 2023
@vstinner

vstinner commented Oct 17, 2023

Copy link
Copy Markdown
Member Author

Extract of PC/pyconfig.h:

#                       if defined(_DEBUG)
#                               pragma comment(lib,"python313_d.lib")
#                       elif defined(Py_LIMITED_API)
#                               pragma comment(lib,"python3.lib")
#                       else
#                               pragma comment(lib,"python313.lib")
#                       endif /* _DEBUG */

In debug mode, extensions are always linked to python313_d.lib. But in release mode, extensions are linked to python3.lib if Py_LIMITED_API is defined.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
pythongh-85283: Fix _ctypes_test build on Windows in release mode
09c9071 
Define Py_BUILD_CORE to not attempt to link the extension to
python3.lib (which fails).
@vstinner
vstinner force-pushed the ctypes_test_core branch from d4aacd3 to 09c9071 Compare October 17, 2023 20:36
@vstinner
vstinner merged commit 2ba6f68 into python:main Oct 17, 2023
@vstinner
vstinner deleted the ctypes_test_core branch October 17, 2023 21:45
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 17, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@vstinner @aisk
pythongh-85283: Fix _ctypes_test build on Windows in release mode (py…
4e57922 
…thon#111005)

Define Py_BUILD_CORE to not attempt to link the extension to
python3.lib (which fails).
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-85283: Fix _ctypes_test build on Windows in release mode (py…
8935c92 
…thon#111005)

Define Py_BUILD_CORE to not attempt to link the extension to
python3.lib (which fails).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.