GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-110950: add upstream Tk fixes to macOS installer. by chrstphrchvz · Pull Request #111041 · python/cpython

Conversation

@chrstphrchvz

@chrstphrchvz chrstphrchvz commented Oct 18, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Secure coding is not enabled for restorable state! WARNING on Mac OS Sonoma 14.0 #110950

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@chrstphrchvz
pythongh-110950: add upstream fix to macOS installer
2cae8a5
@chrstphrchvz
chrstphrchvz requested a review from a team as a code owner October 18, 2023 17:32
@bedevere-app bedevere-app Bot mentioned this pull request Oct 18, 2023
Secure coding is not enabled for restorable state! WARNING on Mac OS Sonoma 14.0 #110950
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Oct 18, 2023
@chrstphrchvz

chrstphrchvz commented Oct 18, 2023

Copy link
Copy Markdown
Contributor Author

As with #108693 and #108806, I have not already attempted to build the macOS installer myself.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
chrstphrchvz added 2 commits October 18, 2023 12:51
@chrstphrchvz
Update backport_gh110950_fix.patch
37ecff3
@chrstphrchvz
Add missing newline at end of NEWS
745ebbe
@hugovk hugovk added OS-mac topic-installation labels Oct 22, 2023
ned-deily added 3 commits November 20, 2023 22:58
@ned-deily
Merge branch 'main' into patch-gh110950
b220624
@ned-deily
Include Tk patches from pythongh-71383 and pythongh-92603
36cee17
@ned-deily
Merge branch 'main' into patch-gh110950
5c93794
@ned-deily ned-deily changed the title gh-110950: add upstream fix to macOS installer gh-110950: add upstream Tk fixes to macOS installer. Nov 21, 2023
ned-deily
ned-deily approved these changes Nov 21, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 21, 2023
@ned-deily
ned-deily merged commit d67f947 into python:main Nov 21, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 21, 2023
@ned-deily ned-deily added topic-tkinter needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes and removed topic-installation labels Nov 21, 2023
@miss-islington-app

miss-islington-app Bot commented Nov 21, 2023

Copy link
Copy Markdown

Thanks @chrstphrchvz for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Nov 21, 2023

Copy link
Copy Markdown

Thanks @chrstphrchvz for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2023
@chrstphrchvz @ned-deily @miss-islington
pythongh-110950: add upstream Tk fixes to macOS installer. (pythonGH-…
79e822d 
…111041)

Add upstream Tk patches for three problems affecting tkinter users:

- Update macOS installer to include a fix accepted by upstream Tcl/Tk
for a crash encountered after the first :meth:`tkinter.Tk` instance
is destroyed. (pythongh-92603)

- Update macOS installer to include an upstream Tcl/Tk fix
for the ``ttk::ThemeChanged`` error encountered in Tkinter. (pythongh-71383)

- Update macOS installer to include an upstream Tcl/Tk fix for the
``Secure coding is not enabled for restorable state!`` warning
encountered in Tkinter on macOS 14 Sonoma. (pythongh-110950)

(cherry picked from commit d67f947)

Co-authored-by: Christopher Chavez <[email protected]>
Co-authored-by: Ned Deily <[email protected]>
@bedevere-app

bedevere-app Bot commented Nov 21, 2023

Copy link
Copy Markdown

GH-112293 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2023
@chrstphrchvz @ned-deily @miss-islington
pythongh-110950: add upstream Tk fixes to macOS installer. (pythonGH-…
d641520 
…111041)

Add upstream Tk patches for three problems affecting tkinter users:

- Update macOS installer to include a fix accepted by upstream Tcl/Tk
for a crash encountered after the first :meth:`tkinter.Tk` instance
is destroyed. (pythongh-92603)

- Update macOS installer to include an upstream Tcl/Tk fix
for the ``ttk::ThemeChanged`` error encountered in Tkinter. (pythongh-71383)

- Update macOS installer to include an upstream Tcl/Tk fix for the
``Secure coding is not enabled for restorable state!`` warning
encountered in Tkinter on macOS 14 Sonoma. (pythongh-110950)

(cherry picked from commit d67f947)

Co-authored-by: Christopher Chavez <[email protected]>
Co-authored-by: Ned Deily <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Nov 21, 2023
@bedevere-app

bedevere-app Bot commented Nov 21, 2023

Copy link
Copy Markdown

GH-112294 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Nov 21, 2023
@chrstphrchvz
chrstphrchvz deleted the patch-gh110950 branch November 21, 2023 08:20
This was referenced Nov 21, 2023
gh-92603: add upstream fix to macOS installer #108693
Closed
gh-71383: add upstream fix to macOS installer #108806
Closed
ned-deily added a commit that referenced this pull request Nov 21, 2023
@miss-islington @chrstphrchvz @ned-deily
[3.11] gh-110950: add upstream Tk fixes to macOS installer. (GH-111041)…
253ad78 
… (#112293)

Add upstream Tk patches for three problems affecting tkinter users:

- Update macOS installer to include a fix accepted by upstream Tcl/Tk
for a crash encountered after the first :meth:`tkinter.Tk` instance
is destroyed. (gh-92603)

- Update macOS installer to include an upstream Tcl/Tk fix
for the ``ttk::ThemeChanged`` error encountered in Tkinter. (gh-71383)

- Update macOS installer to include an upstream Tcl/Tk fix for the
``Secure coding is not enabled for restorable state!`` warning
encountered in Tkinter on macOS 14 Sonoma. (gh-110950)

(cherry picked from commit d67f947)

Co-authored-by: Christopher Chavez <[email protected]>
Co-authored-by: Ned Deily <[email protected]>
ned-deily added a commit that referenced this pull request Nov 21, 2023
@miss-islington @chrstphrchvz @ned-deily
[3.12] gh-110950: add upstream Tk fixes to macOS installer. (GH-111041)…
fab9824 
… (#112294)

Add upstream Tk patches for three problems affecting tkinter users:

- Update macOS installer to include a fix accepted by upstream Tcl/Tk
for a crash encountered after the first :meth:`tkinter.Tk` instance
is destroyed. (gh-92603)

- Update macOS installer to include an upstream Tcl/Tk fix
for the ``ttk::ThemeChanged`` error encountered in Tkinter. (gh-71383)

- Update macOS installer to include an upstream Tcl/Tk fix for the
``Secure coding is not enabled for restorable state!`` warning
encountered in Tkinter on macOS 14 Sonoma. (gh-110950)

(cherry picked from commit d67f947)

Co-authored-by: Christopher Chavez <[email protected]>
Co-authored-by: Ned Deily <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@chrstphrchvz @ned-deily @aisk
pythongh-110950: add upstream Tk fixes to macOS installer. (pythonGH-…
19c76ff 
…111041)

Add upstream Tk patches for three problems affecting tkinter users:

- Update macOS installer to include a fix accepted by upstream Tcl/Tk
for a crash encountered after the first :meth:`tkinter.Tk` instance
is destroyed. (pythongh-92603)

- Update macOS installer to include an upstream Tcl/Tk fix
for the ``ttk::ThemeChanged`` error encountered in Tkinter. (pythongh-71383)

- Update macOS installer to include an upstream Tcl/Tk fix for the
``Secure coding is not enabled for restorable state!`` warning
encountered in Tkinter on macOS 14 Sonoma. (pythongh-110950)

Co-authored-by: Ned Deily <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@chrstphrchvz @ned-deily @Glyphack
pythongh-110950: add upstream Tk fixes to macOS installer. (pythonGH-…
95cecbd 
…111041)

Add upstream Tk patches for three problems affecting tkinter users:

- Update macOS installer to include a fix accepted by upstream Tcl/Tk
for a crash encountered after the first :meth:`tkinter.Tk` instance
is destroyed. (pythongh-92603)

- Update macOS installer to include an upstream Tcl/Tk fix
for the ``ttk::ThemeChanged`` error encountered in Tkinter. (pythongh-71383)

- Update macOS installer to include an upstream Tcl/Tk fix for the
``Secure coding is not enabled for restorable state!`` warning
encountered in Tkinter on macOS 14 Sonoma. (pythongh-110950)

Co-authored-by: Ned Deily <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-mac topic-tkinter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@chrstphrchvz @ned-deily @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.