GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111123: symtable should visit exception handlers before the else block by iritkatriel · Pull Request #111142 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Oct 20, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #111123 .

  • Issue: global declaration in except has incorrect prior use #111123

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
iritkatriel added 2 commits October 20, 2023 23:11
@iritkatriel
pythongh-111123: symtable should visit exception handlers before the …
b76251b 
…else block
@iritkatriel
add news
1db8a70
@iritkatriel iritkatriel added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 20, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 20, 2023
global declaration in except has incorrect prior use #111123
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 20, 2023
@iritkatriel
iritkatriel requested a review from pablogsal October 20, 2023 22:17
iritkatriel
iritkatriel commented Oct 20, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2023-10-20-23-14-06.gh-issue-111123.jjVc3M.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
typo
1e121f8
pablogsal
pablogsal approved these changes Oct 20, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 20, 2023
pablogsal
pablogsal reviewed Oct 20, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2023-10-20-23-14-06.gh-issue-111123.jjVc3M.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 21, 2023
iritkatriel and others added 3 commits October 21, 2023 11:47
@iritkatriel
except* too
72fd4d1
@iritkatriel
add what's new
2216553
@iritkatriel @pablogsal
typo
eafa6d1 
Co-authored-by: Pablo Galindo Salgado <[email protected]>
@iritkatriel
iritkatriel merged commit b578e51 into python:main Oct 21, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 21, 2023
AlexWaygood
AlexWaygood reviewed Oct 21, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst
the file is not accessible.
(Contributed by Moonsik Park in :gh:`82367`.)

* Fixed a bug where a :keyword:`global` decleration in an :keyword:`except` block

@AlexWaygood AlexWaygood Oct 21, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: should be "declaration"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@iritkatriel @aisk
pythongh-111123: symtable should visit exception handlers before the …
56242d5 
…else block (python#111142)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@iritkatriel @Glyphack
pythongh-111123: symtable should visit exception handlers before the …
dca6007 
…else block (python#111142)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@AlexWaygood AlexWaygood AlexWaygood left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

global declaration in except has incorrect prior use

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @pablogsal @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.