GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111181: Fix enum doctests by sobolevn · Pull Request #111180 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Oct 22, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Working on a full description of what is going on.

#111181

📚 Documentation preview 📚: https://cpython-previews--111180.org.readthedocs.build/

  • Issue: enum doctests are silently skipped when run with libregrtest #111181

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sobolevn added 4 commits October 21, 2023 13:26
@sobolevn
WIP
0e5f4da
@sobolevn
Merge branch 'main' into fix-enum-doctests
cf97523
@sobolevn
Demo
a5491b5
@sobolevn
Delete ex.py
60d493e
@sobolevn sobolevn mentioned this pull request Oct 22, 2023
enum doctests are silently skipped when run with libregrtest #111181
Closed
@sobolevn sobolevn changed the title Fix enum doctests gh-111181: Fix enum doctests Oct 22, 2023
@sobolevn

sobolevn commented Oct 22, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@ethanfurman as I said I am not sure that my fixes are correct, I just want to show you that there are some broken tests at the moment. I need your help with the details :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka approved these changes Oct 23, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting merge label Oct 23, 2023
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 23, 2023
@ethanfurman

ethanfurman commented Oct 23, 2023

Copy link
Copy Markdown
Member

Thank you for getting the doc tests to always run. I'll work on getting the doc tests correct.
sobolevn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ethanfurman ethanfurman self-assigned this Oct 23, 2023
@ethanfurman
update code to match documentation
766639a
@sobolevn
sobolevn marked this pull request as ready for review October 28, 2023 06:03
@sobolevn
sobolevn requested a review from ethanfurman as a code owner October 28, 2023 06:03
@bedevere-app bedevere-app Bot added awaiting review and removed awaiting merge labels Oct 28, 2023
ethanfurman
ethanfurman approved these changes Oct 30, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 30, 2023
@ethanfurman
ethanfurman merged commit c4dc5a6 into python:main Oct 30, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 30, 2023
@miss-islington-app

miss-islington-app Bot commented Oct 30, 2023

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Oct 30, 2023

Copy link
Copy Markdown

Sorry, @sobolevn and @ethanfurman, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c4dc5a6ae8aa13abb743182df088f1a3526d1bcd 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 30, 2023
@sobolevn @ethanfurman @miss-islington
pythongh-111181: Fix enum doctests (pythonGH-111180)
a3ee1bc 
(cherry picked from commit c4dc5a6)

Co-authored-by: Nikita Sobolev <[email protected]>
Co-authored-by: Ethan Furman <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 30, 2023

Copy link
Copy Markdown

GH-111518 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 30, 2023
ethanfurman added a commit that referenced this pull request Oct 31, 2023
@miss-islington @sobolevn @ethanfurman
[3.12] gh-111181: Fix enum doctests (GH-111180) (GH-111518)
ec00397 
gh-111181: Fix enum doctests (GH-111180)
(cherry picked from commit c4dc5a6)

Co-authored-by: Nikita Sobolev <[email protected]>
Co-authored-by: Ethan Furman <[email protected]>
ethanfurman added a commit to ethanfurman/cpython that referenced this pull request Nov 1, 2023
@sobolevn @ethanfurman
pythongh-111181: Fix enum doctests (pythonGH-111180)
db862fc 
Co-authored-by: Ethan Furman <[email protected]>
(cherry picked from commit c4dc5a6)
@bedevere-app

bedevere-app Bot commented Nov 1, 2023

Copy link
Copy Markdown

GH-111617 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Nov 1, 2023
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@sobolevn @ethanfurman @FullteaR
pythongh-111181: Fix enum doctests (pythonGH-111180)
248d504 
Co-authored-by: Ethan Furman <[email protected]>
@sobolevn sobolevn mentioned this pull request Nov 3, 2023
Decide what should we do with doctests in CI #111704
Open
ethanfurman added a commit that referenced this pull request Nov 3, 2023
@ethanfurman @sobolevn
[3.11] gh-111181: Fix enum doctests (GH-111180) (GH-111617)
4a61169 
gh-111181: Fix enum doctests (GH-111180)

Co-authored-by: Ethan Furman <[email protected]>
(cherry picked from commit c4dc5a6)

Co-authored-by: Nikita Sobolev <[email protected]>
@ethanfurman ethanfurman mentioned this pull request Dec 20, 2023
gh-104235: Fix doctest loading issues in test_enum #104236
Closed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @ethanfurman @aisk
pythongh-111181: Fix enum doctests (pythonGH-111180)
97228d9 
Co-authored-by: Ethan Furman <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @ethanfurman @Glyphack
pythongh-111181: Fix enum doctests (pythonGH-111180)
3303674 
Co-authored-by: Ethan Furman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@ethanfurman ethanfurman ethanfurman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ethanfurman ethanfurman

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @ethanfurman @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.