GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111187: Postpone removal version for locale.getdefaultlocale() to 3.15 by hugovk · Pull Request #111188 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Oct 22, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Should we update What's New in 3.11 and 3.12?

Should we backport these changes to 3.11 and 3.12?

  • Issue: Postpone removal version for locale.getdefaultlocale() #111187

📚 Documentation preview 📚: https://cpython-previews--111188.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Update removal version for locale.getdefaultlocale() to 3.15
aa1ebfa
@bedevere-app bedevere-app Bot mentioned this pull request Oct 22, 2023
Postpone removal version for locale.getdefaultlocale() #111187
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 22, 2023
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 22, 2023
@hugovk
Add NEWS
0a4eac7
@hugovk hugovk changed the title gh-111187: Update removal version for locale.getdefaultlocale() to 3.15 gh-111187: Postpone removal version for locale.getdefaultlocale() to 3.15 Oct 22, 2023
@hugovk hugovk mentioned this pull request Oct 22, 2023
Remove locale.resetlocale() function in Python 3.13 #104783
Closed
methane
methane approved these changes Oct 25, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 25, 2023
@hugovk
hugovk merged commit 81ed80d into python:main Oct 25, 2023
@hugovk
hugovk deleted the 3.15-locale.setlocale branch October 25, 2023 13:47
@miss-islington-app

miss-islington-app Bot commented Oct 25, 2023

Copy link
Copy Markdown

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 25, 2023
@miss-islington-app

miss-islington-app Bot commented Oct 25, 2023

Copy link
Copy Markdown

Sorry, @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 81ed80d843b3f6f0109e7ad854af2c5de27e1a89 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned hugovk Oct 25, 2023
@miss-islington-app

miss-islington-app Bot commented Oct 25, 2023

Copy link
Copy Markdown

Sorry, @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 81ed80d843b3f6f0109e7ad854af2c5de27e1a89 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Oct 25, 2023

Copy link
Copy Markdown

GH-111323 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 25, 2023
hugovk added a commit to hugovk/cpython that referenced this pull request Oct 25, 2023
@hugovk
[3.12] pythongh-111187: Postpone removal version for locale.getdefaul…
98e4053 
…tlocale() to 3.15 (pythonGH-111188).

(cherry picked from commit 81ed80d)

Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit to hugovk/cpython that referenced this pull request Oct 25, 2023
@hugovk
fixup! [3.11] pythongh-111187: Postpone removal version for locale.ge…
3c1b48b 
…tdefaultlocale() to 3.15 (pythonGH-111188). (cherry picked from commit 81ed80d)
hugovk added a commit to hugovk/cpython that referenced this pull request Oct 25, 2023
@hugovk
fixup! [3.11] pythongh-111187: Postpone removal version for locale.ge…
5e7cee6 
…tdefaultlocale() to 3.15 (pythonGH-111188). (cherry picked from commit 81ed80d)
hugovk added a commit to hugovk/cpython that referenced this pull request Oct 25, 2023
@hugovk
[3.11] pythongh-111187: Postpone removal version for locale.getdefaul…
45ac3a8 
…tlocale() to 3.15 (pythonGH-111188).

(cherry picked from commit 81ed80d)

Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit to hugovk/cpython that referenced this pull request Oct 25, 2023
@hugovk
[3.11] pythongh-111187: Postpone removal version for locale.getdefaul…
ad19819 
…tlocale() to 3.15 (pythonGH-111188).

(cherry picked from commit 81ed80d)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 25, 2023

Copy link
Copy Markdown

GH-111326 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Oct 25, 2023
hugovk added a commit that referenced this pull request Oct 27, 2023
@hugovk
[3.12] gh-111187: Postpone removal version for locale.getdefaultlocal…
7d22e85 
…e() to 3.15 (GH-111188) (#111323)
hugovk added a commit that referenced this pull request Oct 27, 2023
@hugovk
[3.11] gh-111187: Postpone removal version for locale.getdefaultlocal…
e7cdccc 
…e() to 3.15 (GH-111188) (#111326)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@hugovk @aisk
pythongh-111187: Postpone removal version for locale.getdefaultlocale…
bfffe18 
…() to 3.15 (python#111188)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@hugovk @Glyphack
pythongh-111187: Postpone removal version for locale.getdefaultlocale…
84ad68e 
…() to 3.15 (python#111188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hugovk hugovk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @methane
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.