GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-110383: Italicize variable name by Nikki1993 · Pull Request #111206 · python/cpython

Conversation

@Nikki1993

@Nikki1993 Nikki1993 commented Oct 23, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Corrects an issue present in merged PR #111110

  • Issue: Issues from [email protected] #110383

📚 Documentation preview 📚: https://cpython-previews--111206.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Nikki1993
Actually do italics this time
c95262f
@bedevere-app bedevere-app Bot added the awaiting review label Oct 23, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 23, 2023
Issues from [email protected] #110383
Closed
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Oct 23, 2023
hugovk
hugovk approved these changes Oct 23, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Confirmed via the build preview: https://cpython-previews--111206.org.readthedocs.build/en/111206/howto/regex.html

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 23, 2023
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 23, 2023
@hugovk
hugovk enabled auto-merge (squash) October 23, 2023 07:52
@hugovk
hugovk merged commit c84b039 into python:main Oct 23, 2023
@miss-islington-app

miss-islington-app Bot commented Oct 23, 2023

Copy link
Copy Markdown

Thanks @Nikki1993 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 23, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 23, 2023
@Nikki1993 @miss-islington
pythongh-110383: Italicize variable name (pythonGH-111206)
93d606b 
(cherry picked from commit c84b039)

Co-authored-by: Nick <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 23, 2023
@Nikki1993 @miss-islington
pythongh-110383: Italicize variable name (pythonGH-111206)
ab79db1 
(cherry picked from commit c84b039)

Co-authored-by: Nick <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 23, 2023

Copy link
Copy Markdown

GH-111207 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 23, 2023
@bedevere-app

bedevere-app Bot commented Oct 23, 2023

Copy link
Copy Markdown

GH-111208 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Oct 23, 2023
hugovk pushed a commit that referenced this pull request Oct 23, 2023
@miss-islington @Nikki1993
[3.12] gh-110383: Italicize variable name (GH-111206) (#111207)
4d781bc 
Co-authored-by: Nick <[email protected]>
hugovk pushed a commit that referenced this pull request Oct 23, 2023
@miss-islington @Nikki1993
[3.11] gh-110383: Italicize variable name (GH-111206) (#111208)
0a23960 
Co-authored-by: Nick <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@Nikki1993 @aisk
pythongh-110383: Italicize variable name (python#111206)
6cfaa66
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@Nikki1993 @Glyphack
pythongh-110383: Italicize variable name (python#111206)
788dbae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Nikki1993 @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.