GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-111049: Fix crash during garbage collection of the BytesIO buffer object by serhiy-storchaka · Pull Request #111221 · python/cpython

Conversation

serhiy-storchaka commented Oct 23, 2023 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: Segfault during garbage collection with GzipFile + failed urllib3 request on 3.12.0 #111049

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-111049: Fix crash during garbage collection of the BytesIO b…

d2d8ed2

…uffer object

serhiy-storchaka added the needs backport to 3.12 only security fixes label

Oct 23, 2023

bedevere-app Bot mentioned this pull request

Oct 23, 2023

Segfault during garbage collection with GzipFile + failed urllib3 request on 3.12.0 #111049

Closed

bedevere-app Bot added the awaiting core review label

Oct 23, 2023

serhiy-storchaka commented

Oct 23, 2023

View reviewed changes

Comment thread

Lib/test/test_memoryio.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_memoryio.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/_io/bytesio.c Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Remove debugging remnants.

131142b

erlend-aasland requested review from erlend-aasland and kumaraditya303

October 23, 2023 18:41


          Merge branch 'main' into crash-bytesio-getbuffer-gc

160896f

erlend-aasland requested changes

Oct 25, 2023

View reviewed changes

Comment thread

Lib/test/test_memoryio.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting core review label

Oct 25, 2023

bedevere-app Bot commented Oct 25, 2023

Copy link

Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot added the awaiting changes label

Oct 25, 2023

serhiy-storchaka added 2 commits

October 25, 2023 18:03


          Merge branch 'main' into crash-bytesio-getbuffer-gc

10ed7d0


          Merge remote-tracking branch 'refs/remotes/origin/crash-bytesio-getbu…

57fa654

…ffer-gc' into crash-bytesio-getbuffer-gc

furkanonder added the type-crash A hard crash of the interpreter, possibly with a core dump label

Oct 26, 2023

serhiy-storchaka commented Oct 30, 2023

Copy link

Copy Markdown

Member Author

@erlend-aasland I do not understand, what exactly changes did you request. Could you please explain it in more details?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added 2 commits

October 30, 2023 17:29


          Address review comments.

cb70991


          Merge branch 'main' into crash-bytesio-getbuffer-gc

046362f

serhiy-storchaka commented Oct 30, 2023

Copy link

Copy Markdown

Member Author

Thank you for your suggestion @erlend-aasland. I have made the requested changes; please review again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

basepi commented Oct 30, 2023

Copy link

Copy Markdown

I have made the requested changes; please review again.

I think this needs to be in a comment by itself, looks like the bot didn't remove the label.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood commented Oct 30, 2023

Copy link

Copy Markdown

Member

I have made the requested changes; please review again.

I think this needs to be in a comment by itself, looks like the bot didn't remove the label.

no, the bot is malfunctioning at the moment:

Bedevere doesn't say "thank you" for making the requested changes anymore bedevere#599

basepi reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reviewed

Oct 31, 2023

View reviewed changes

Comment thread

Lib/test/test_memoryio.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_memoryio.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

basepi commented Nov 13, 2023

Copy link

Copy Markdown

Any movement here? It would be lovely to get this fix into 3.12.1.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland requested changes

Nov 15, 2023

View reviewed changes

erlend-aasland left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the XXX from the comments as per PEP-8:

Ensure that your comments are clear and easily understandable to other speakers of the language you are writing in.

Python coders from non-English speaking countries: please write your comments in English, unless you are 120% sure that the code will never be read by people who don’t speak your language.

XXX is neither clear, easily understandable, nor english; please remove it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_memoryio.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_memoryio.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

basepi commented Dec 11, 2023

Copy link

Copy Markdown

@serhiy-storchaka Can you please remove the instances of XXX so we can get this merged? Frustrated that we missed 3.12.1 with this fix.

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

basepi mentioned this pull request

Dec 11, 2023

build(deps): Bump python from 3.11.5-slim to 3.12.1-slim elastic/opbeans-python#306

Closed

erlend-aasland and others added 3 commits

December 11, 2023 23:20


          Merge branch 'main' into crash-bytesio-getbuffer-gc

47f20ea


          Merge branch 'main' into crash-bytesio-getbuffer-gc

be1ea22


          Remove XXX comments.

621345b

serhiy-storchaka force-pushed the crash-bytesio-getbuffer-gc branch from 0c693c0 to 621345b Compare

December 14, 2023 09:44

erlend-aasland approved these changes

Dec 14, 2023

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting changes labels

Dec 14, 2023

serhiy-storchaka commented Dec 14, 2023

Copy link

Copy Markdown

Member Author

I decided to remove them at all. I tried to silence errors, but they serve as indication of programming error, similar to ResourceWarning. When memoryview is explicitly released or used as a context manager, this never happens.

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka enabled auto-merge (squash)

December 14, 2023 09:51

serhiy-storchaka merged commit bb36f72 into python:main

Dec 14, 2023

This comment was marked as outdated.

bedevere-app Bot removed the awaiting merge label

Dec 14, 2023

bedevere-app Bot commented Dec 14, 2023

Copy link

Copy Markdown

GH-113096 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Dec 14, 2023


          pythongh-111049: Fix crash during garbage collection of the BytesIO b…

fc4cf50

…uffer object (pythonGH-111221)

(cherry picked from commit bb36f72)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Dec 14, 2023

serhiy-storchaka added a commit that referenced this pull request

Dec 14, 2023


          [3.12] gh-111049: Fix crash during garbage collection of the BytesIO …

9f5209f

…buffer object (GH-111221) (GH-113096)

(cherry picked from commit bb36f72)

Co-authored-by: Serhiy Storchaka <[email protected]>

corona10 pushed a commit to corona10/cpython that referenced this pull request

Dec 15, 2023


          pythongh-111049: Fix crash during garbage collection of the BytesIO b…

43fea31

…uffer object (pythonGH-111221)

basepi mentioned this pull request

Jan 18, 2024

Segfault for short-lived Client objects in python 3.12 elastic/apm-agent-python#1916

Closed

aisk pushed a commit to aisk/cpython that referenced this pull request

Feb 11, 2024


          pythongh-111049: Fix crash during garbage collection of the BytesIO b…

db183c4

…uffer object (pythonGH-111221)

serhiy-storchaka deleted the crash-bytesio-getbuffer-gc branch

March 12, 2024 10:11

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024


          pythongh-111049: Fix crash during garbage collection of the BytesIO b…

2a1f6ae

…uffer object (pythonGH-111221)

Reviewers

erlend-aasland

erlend-aasland approved these changes

kumaraditya303

Awaiting requested review from kumaraditya303

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-crash

A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

serhiy-storchaka commented Oct 23, 2023 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-app Bot commented Oct 25, 2023

Uh oh!

serhiy-storchaka commented Oct 30, 2023

Uh oh!

serhiy-storchaka commented Oct 30, 2023

Uh oh!

basepi commented Oct 30, 2023

Uh oh!

AlexWaygood commented Oct 30, 2023

Uh oh!

Uh oh!

Uh oh!

basepi commented Nov 13, 2023

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

basepi commented Dec 11, 2023

Uh oh!

serhiy-storchaka commented Dec 14, 2023

Uh oh!

This comment was marked as outdated.

bedevere-app Bot commented Dec 14, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

serhiy-storchaka commented Oct 23, 2023 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.