GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94438: Add additional cases to mark_stacks with tests by savannahostrowski · Pull Request #111237 · python/cpython

Conversation

@savannahostrowski

@savannahostrowski savannahostrowski commented Oct 23, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

After reading through #94438, it appeared that there were still outstanding issues with mark_stacks as there was no case that checking for POP_JUMP_IF_NONE and POP_JUMP_IF_NOT_NONE, which could break pdb's jump in 3.11 or higher. This adds these case to the switch statement plus a couple of tests.

  • Issue: frame.setlineno has serious flaws. #94438

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brandtbucher reacted with hooray emoji
All reactions
  • 🎉 1 reaction
savannahostrowski added 2 commits October 22, 2023 13:03
@savannahostrowski
Adds test case for JUMP_IS_NONE
cbde4e9
@savannahostrowski
Add tests
eb224c4
@savannahostrowski
savannahostrowski requested a review from markshannon as a code owner October 23, 2023 21:58
@ghost

ghost commented Oct 23, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Oct 23, 2023
frame.setlineno has serious flaws. #94438
Closed
3 tasks done
@bedevere-app bedevere-app Bot added the awaiting review label Oct 23, 2023
@bedevere-app

bedevere-app Bot commented Oct 23, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@savannahostrowski

savannahostrowski commented Oct 23, 2023

Copy link
Copy Markdown
Member Author

cc: @brandtbucher
brandtbucher reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brandtbucher brandtbucher self-assigned this Oct 23, 2023
@brandtbucher
brandtbucher self-requested a review October 23, 2023 22:00
@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 23, 2023
@brandtbucher

brandtbucher commented Oct 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(Note to self that the 3.11 backport will probably need to be manual.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@savannahostrowski
Appease linter
c2b4538
@bedevere-app

bedevere-app Bot commented Oct 23, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@blurb-it
📜🤖 Added by blurb_it.
40b2ca8
brandtbucher
brandtbucher requested changes Oct 23, 2023
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for this! This is some really tricky code.

Just a couple of comments on the tests:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
savannahostrowski reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread Lib/test/test_sys_settrace.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Core and Builtins/2023-10-23-22-11-09.gh-issue-94438.y2pITu.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_sys_settrace.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting review labels Oct 23, 2023
@bedevere-app

bedevere-app Bot commented Oct 23, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Savannah Ostrowski
Update tests for line numbers and blurb it for backticks
2b198b8
brandtbucher
brandtbucher reviewed Oct 23, 2023
View reviewed changes
Comment thread Lib/test/test_sys_settrace.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@savannahostrowski
Update tests
33fd711
@savannahostrowski
savannahostrowski force-pushed the jump_if_none branch from 6405fe0 to 33fd711 Compare October 23, 2023 23:07
brandtbucher
brandtbucher reviewed Oct 23, 2023
View reviewed changes
Comment thread Lib/test/test_sys_settrace.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Savannah Ostrowski @brandtbucher
Update Lib/test/test_sys_settrace.py
0143197 
Co-authored-by: Brandt Bucher <[email protected]>
@brandtbucher

brandtbucher commented Oct 24, 2023

Copy link
Copy Markdown
Member

Sorry, one last thing... can you add yourself to Misc/ACKS? :)
savannahostrowski reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@savannahostrowski
Add myself to ACKS
80e1ba4
brandtbucher
brandtbucher approved these changes Oct 24, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting changes labels Oct 24, 2023
@brandtbucher
brandtbucher merged commit 6640f1d into python:main Oct 24, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 24, 2023
@miss-islington-app

miss-islington-app Bot commented Oct 24, 2023

Copy link
Copy Markdown

Thanks @savannahostrowski for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Oct 24, 2023

Copy link
Copy Markdown

Sorry, @savannahostrowski and @brandtbucher, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6640f1d8d2462ca0877e1d2789e1721767e9caf2 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2023
Savannah Ostrowski @miss-islington
pythonGH-94438: Restore ability to jump over None tests (pythonGH-111237
2c77dfb 
)

(cherry picked from commit 6640f1d)

Co-authored-by: Savannah Ostrowski <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 24, 2023

Copy link
Copy Markdown

GH-111243 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 24, 2023
@willingc

willingc commented Oct 24, 2023

Copy link
Copy Markdown
Contributor

Congrats @savannahostrowski for the successful contribution. 🎉

@brandtbucher 😄
brandtbucher and savannahostrowski reacted with hooray emoji
All reactions
  • 🎉 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@savannahostrowski savannahostrowski mentioned this pull request Oct 25, 2023
[3.11] GH-94438: Restore ability to jump over None tests (GH-111237) #111338
Merged
@bedevere-app

bedevere-app Bot commented Oct 25, 2023

Copy link
Copy Markdown

GH-111338 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Oct 25, 2023
@gaogaotiantian gaogaotiantian mentioned this pull request Oct 26, 2023
GH-94438: Fix RuntimeWarning for jump tests in test_sys_settrace #111341
Merged
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Savannah Ostrowski @aisk
pythonGH-94438: Restore ability to jump over None tests (pythonGH-111237
d9715b6 
)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Savannah Ostrowski @Glyphack
pythonGH-94438: Restore ability to jump over None tests (pythonGH-111237
a721258 
)
@savannahostrowski
savannahostrowski deleted the jump_if_none branch September 27, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandtbucher brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@savannahostrowski @brandtbucher @willingc
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.