GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111253: Fix socketmodule.c not checking for errors when initializing by sobolevn · Pull Request #111254 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Oct 24, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: socketmodule.c does not handle errors on module creation extension-modules  #111253

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-111253: Fix socketmodule.c not checking for errors when init…
63bc51d 
…ializing
@sobolevn
sobolevn requested review from erlend-aasland, serhiy-storchaka and vstinner October 24, 2023 09:21
@bedevere-app bedevere-app Bot mentioned this pull request Oct 24, 2023
socketmodule.c does not handle errors on module creation extension-modules #111253
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Oct 24, 2023
serhiy-storchaka
serhiy-storchaka approved these changes Oct 24, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 24, 2023
erlend-aasland
erlend-aasland reviewed Oct 25, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2023-10-24-12-20-46.gh-issue-111253.HFywSK.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Adjust NEWS entry
69502aa
@erlend-aasland
erlend-aasland enabled auto-merge (squash) October 25, 2023 06:44
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 25, 2023
@erlend-aasland
erlend-aasland merged commit 3052c09 into python:main Oct 25, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 25, 2023
@miss-islington-app

miss-islington-app Bot commented Oct 25, 2023

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Oct 25, 2023

Copy link
Copy Markdown

Sorry, @sobolevn and @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3052c098ca2779c2d9ab9800dabe66d0efa01794 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 25, 2023
@sobolevn @miss-islington
pythongh-111253: Fix error checking in _socket module init (pythonGH-…
92cc30d 
…111254)

(cherry picked from commit 3052c09)

Co-authored-by: Nikita Sobolev <[email protected]>
@miss-islington-app miss-islington-app Bot assigned erlend-aasland Oct 25, 2023
@bedevere-app

bedevere-app Bot commented Oct 25, 2023

Copy link
Copy Markdown

GH-111299 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 25, 2023
vstinner pushed a commit that referenced this pull request Nov 1, 2023
@miss-islington @sobolevn
[3.12] gh-111253: Fix error checking in _socket module init (GH-111254)…
99f0dd8 
… (#111299)

gh-111253: Fix error checking in _socket module init (GH-111254)
(cherry picked from commit 3052c09)

Co-authored-by: Nikita Sobolev <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @aisk
pythongh-111253: Fix error checking in _socket module init (python#11…
2b69e40 
…1254)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @Glyphack
pythongh-111253: Fix error checking in _socket module init (python#11…
e146dd9 
…1254)
@ZeroIntensity ZeroIntensity removed the needs backport to 3.11 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@erlend-aasland erlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @serhiy-storchaka @erlend-aasland @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.