GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-109017: Use non alternate name for Kyiv (GH-109251) by miss-islington · Pull Request #111280 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 24, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
(cherry picked from commit 46407fe)

Co-authored-by: Jochen Sprickerhof [email protected]

  • Issue: Use Kyiv instead of Kiev in test_email #109017

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jspricke @miss-islington
pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)
1b56294 
tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
(cherry picked from commit 46407fe)

Co-authored-by: Jochen Sprickerhof <[email protected]>
@miss-islington
miss-islington requested a review from a team as a code owner October 24, 2023 17:13
@bedevere-app bedevere-app Bot mentioned this pull request Oct 24, 2023
Use Kyiv instead of Kiev in test_email #109017
Closed
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Oct 24, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 24, 2023
gh-109017: Use non alternate name for Kyiv #109251
Merged
@bedevere-app bedevere-app Bot added the skip news label Oct 24, 2023
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) October 24, 2023 17:14
@serhiy-storchaka
serhiy-storchaka merged commit b6e508c into python:3.12 Oct 24, 2023
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 24, 2023
@miss-islington
miss-islington deleted the backport-46407fe-3.12 branch January 2, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @serhiy-storchaka @jspricke
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.