GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-109017: Use non alternate name for Kyiv by jspricke · Pull Request #109251 · python/cpython

Conversation

jspricke commented Sep 11, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

tzdata provides Kiev as an alternative to Kyiv:

https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314#L314

But Debian moved it to the tzdata-legacy package breaking the test:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.

Issue: Use Kyiv instead of Kiev in test_email #109017

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

jspricke requested a review from a team as a code owner

September 11, 2023 04:43

bedevere-bot added awaiting review tests Tests in the Lib/test dir labels

Sep 11, 2023

bedevere-bot mentioned this pull request

Sep 11, 2023

Use Kyiv instead of Kiev in test_email #109017

Closed

serhiy-storchaka self-assigned this

Sep 11, 2023

jspricke force-pushed the fix_kyiv branch from 43a38cf to f7545ea Compare

September 11, 2023 06:32

serhiy-storchaka reviewed

Sep 11, 2023

View reviewed changes

Comment thread

Lib/test/test_email/test_utils.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          pythongh-109017: Use non alternate name for Kyiv

b10798b

tzdata provides Kiev as an alternative to Kyiv:

https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314#L314

But Debian moved it to the tzdata-legacy package breaking the test:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.

jspricke force-pushed the fix_kyiv branch from f7545ea to b10798b Compare

September 11, 2023 06:39

serhiy-storchaka reviewed

Sep 11, 2023

View reviewed changes

Comment thread

Lib/test/test_email/test_utils.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update Lib/test/test_email/test_utils.py

2510b90

serhiy-storchaka added the skip news label

Sep 11, 2023

serhiy-storchaka commented Sep 11, 2023

Copy link

Copy Markdown

Member

Very well. Tested on Windows, so the check works.

Now I'm waiting for our buildbots to be fixed (they're not very stable at the moment), then I'll run tests with this PR on the buildbots, and if they pass, I'll merge the PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge branch 'main' into fix_kyiv

d12532a

serhiy-storchaka added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label

Sep 12, 2023

bedevere-bot commented Sep 12, 2023

Copy link

Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit d12532a 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label

Sep 12, 2023


          Merge branch 'main' into fix_kyiv

496d9c3

AA-Turner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label

Sep 21, 2023

bedevere-bot commented Sep 21, 2023

Copy link

Copy Markdown

🤖 New build scheduled with the buildbot fleet by @AA-Turner for commit 496d9c3 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label

Sep 21, 2023


          Merge branch 'main' into fix_kyiv

fff7bb4

serhiy-storchaka removed the request for review from a team

October 24, 2023 07:42

serhiy-storchaka added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label

Oct 24, 2023

bedevere-bot commented Oct 24, 2023

Copy link

Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit fff7bb4 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label

Oct 24, 2023

serhiy-storchaka merged commit 46407fe into python:main

Oct 24, 2023

bedevere-app Bot removed the awaiting review label

Oct 24, 2023

serhiy-storchaka added needs backport to 3.11

only security fixes

needs backport to 3.12 only security fixes labels

Oct 24, 2023

miss-islington-app Bot commented Oct 24, 2023

Copy link

Copy Markdown

Thanks @jspricke for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Oct 24, 2023

Copy link

Copy Markdown

Thanks @jspricke for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 24, 2023


          pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)

59db316

tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
(cherry picked from commit 46407fe)

Co-authored-by: Jochen Sprickerhof <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 24, 2023


          pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)

1b56294

tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
(cherry picked from commit 46407fe)

Co-authored-by: Jochen Sprickerhof <[email protected]>

bedevere-app Bot commented Oct 24, 2023

Copy link

Copy Markdown

GH-111279 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label

Oct 24, 2023

bedevere-app Bot commented Oct 24, 2023

Copy link

Copy Markdown

GH-111280 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Oct 24, 2023

serhiy-storchaka pushed a commit that referenced this pull request

Oct 24, 2023


          [3.12] gh-109017: Use non alternate name for Kyiv (GH-109251) (GH-111280

b6e508c

)

tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
(cherry picked from commit 46407fe)

Co-authored-by: Jochen Sprickerhof <[email protected]>

serhiy-storchaka pushed a commit that referenced this pull request

Oct 24, 2023


          [3.11] gh-109017: Use non alternate name for Kyiv (GH-109251) (GH-111279

652d3f3

)

tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
(cherry picked from commit 46407fe)

Co-authored-by: Jochen Sprickerhof <[email protected]>

aisk pushed a commit to aisk/cpython that referenced this pull request

Feb 11, 2024


          pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)

ac32394

tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314#L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.

stefanor mentioned this pull request

Aug 30, 2024

Use Kyiv instead of Kiev pypy/pypy#5014

Merged

mattip pushed a commit to pypy/pypy that referenced this pull request

Aug 30, 2024


          Use Kyiv instead of Kiev

c30af4d

tzdata provides Kiev as an alternative to Kyiv, but Debian moved it to
the tzdata-legacy package, breaking these tests.

cPython also uses this timezone in test_email, and this was fixed in
3.11. I've left that patch out of here, it will get picked up when PyPy
switches to 3.11 stdlib.

python/cpython#109251

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024


          pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)

8fbaa03

tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314#L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.

serhiy-storchaka removed their assignment

Jul 15, 2026

Reviewers

serhiy-storchaka

serhiy-storchaka left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

jspricke commented Sep 11, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka commented Sep 11, 2023

Uh oh!

bedevere-bot commented Sep 12, 2023

Uh oh!

bedevere-bot commented Sep 21, 2023

Uh oh!

bedevere-bot commented Oct 24, 2023

Uh oh!

miss-islington-app Bot commented Oct 24, 2023

Uh oh!

miss-islington-app Bot commented Oct 24, 2023

Uh oh!

bedevere-app Bot commented Oct 24, 2023

Uh oh!

bedevere-app Bot commented Oct 24, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jspricke commented Sep 11, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.