GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111282: Fix NamedTemporaryFile example code by kkarbowiak · Pull Request #111283 · python/cpython

Conversation

@kkarbowiak

@kkarbowiak kkarbowiak commented Oct 24, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Error in example of tempfile module #111282

📚 Documentation preview 📚: https://cpython-previews--111283.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kkarbowiak
Fix NamedTemporaryFile example code
c22010e
@bedevere-app bedevere-app Bot mentioned this pull request Oct 24, 2023
Error in example of tempfile module #111282
Closed
@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 24, 2023
@Eclips4 Eclips4 added the needs backport to 3.12 only security fixes label Oct 24, 2023
Eclips4
Eclips4 reviewed Oct 24, 2023
View reviewed changes
Comment thread Doc/library/tempfile.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
kkarbowiak added 2 commits October 24, 2023 21:46
@kkarbowiak
Fix indentation
86b6d46
@kkarbowiak
Fix comments indentation
8f8886e
Eclips4
Eclips4 approved these changes Oct 24, 2023
View reviewed changes

@Eclips4 Eclips4 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Oct 24, 2023
zware
zware reviewed Oct 30, 2023
View reviewed changes
Comment thread Doc/library/tempfile.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kkarbowiak
Fix open mode
0b98923
zware
zware approved these changes Oct 31, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 31, 2023
@zware
zware merged commit 102685c into python:main Oct 31, 2023
@miss-islington-app

miss-islington-app Bot commented Oct 31, 2023

Copy link
Copy Markdown

Thanks @kkarbowiak for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 31, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2023
@kkarbowiak @miss-islington
pythongh-111282: Fix NamedTemporaryFile example code (pythonGH-111283)
d7a2f3a 
(cherry picked from commit 102685c)

Co-authored-by: Krzysiek Karbowiak <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 31, 2023

Copy link
Copy Markdown

GH-111579 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 31, 2023
zware pushed a commit that referenced this pull request Oct 31, 2023
@miss-islington @kkarbowiak
[3.12] gh-111282: Fix NamedTemporaryFile example code (GH-111283) (GH…
21c8fbf 
…-111579)

(cherry picked from commit 102685c)

Co-authored-by: Krzysiek Karbowiak <[email protected]>
@kkarbowiak
kkarbowiak deleted the fix-issue-gh111282 branch October 31, 2023 22:17
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@kkarbowiak @FullteaR
pythongh-111282: Fix NamedTemporaryFile example code (pythonGH-111283)
b0b2341
@sobolevn sobolevn mentioned this pull request Nov 3, 2023
Decide what should we do with doctests in CI #111704
Open
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@kkarbowiak @aisk
pythongh-111282: Fix NamedTemporaryFile example code (pythonGH-111283)
57fcaa0
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@kkarbowiak @Glyphack
pythongh-111282: Fix NamedTemporaryFile example code (pythonGH-111283)
8b55c24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware approved these changes
@Eclips4 Eclips4 Eclips4 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@kkarbowiak @zware @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.