GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111354: define names for RESUME oparg values by iritkatriel · Pull Request #111365 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Oct 26, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Small readability improvement.

  • Issue: remove hacks in genobject.c #111354

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-111354: define names for RESUME oparg values
d6eaf2c
@iritkatriel
iritkatriel requested a review from markshannon as a code owner October 26, 2023 14:29
@bedevere-app bedevere-app Bot mentioned this pull request Oct 26, 2023
remove hacks in genobject.c #111354
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 26, 2023
iritkatriel added 3 commits October 26, 2023 15:30
@iritkatriel
add missing include
74a6d8c
@iritkatriel
use definition in bytecodes.c as well
754fd74
@iritkatriel
and in genobject.c
0e7a692
@iritkatriel
iritkatriel force-pushed the resume branch from f516368 to 0e7a692 Compare October 26, 2023 14:44
markshannon
markshannon approved these changes Oct 26, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 26, 2023
@markshannon markshannon added the skip news label Oct 26, 2023
@iritkatriel
iritkatriel merged commit a0c414c into python:main Oct 26, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 26, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@iritkatriel @aisk
pythongh-111354: define names for RESUME oparg values (python#111365)
7edc25e
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@iritkatriel @Glyphack
pythongh-111354: define names for RESUME oparg values (python#111365)
6c87cac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@iritkatriel @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.