GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix typos in import system docs by jonathanberthias · Pull Request #111396 · python/cpython

Conversation

@jonathanberthias

@jonathanberthias jonathanberthias commented Oct 27, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The word instead is duplicated a few times in soft deprecation notes. Maybe it was to add even more emphasis? 😛

📚 Documentation preview 📚: https://cpython-previews--111396.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jonathanberthias
Fix typos in import system docs
3a89a8b
@jonathanberthias
jonathanberthias requested review from brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners October 27, 2023 13:09
@ghost

ghost commented Oct 27, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 27, 2023
@Eclips4 Eclips4 added the skip issue label Oct 27, 2023
Eclips4
Eclips4 approved these changes Oct 27, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Oct 27, 2023
AlexWaygood
AlexWaygood approved these changes Oct 27, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jonathanberthias reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 27, 2023
@AlexWaygood
AlexWaygood enabled auto-merge (squash) October 27, 2023 13:20
@AlexWaygood
AlexWaygood merged commit 9a2f2f4 into python:main Oct 27, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 27, 2023
@AlexWaygood AlexWaygood added the needs backport to 3.12 only security fixes label Oct 27, 2023
@miss-islington-app

miss-islington-app Bot commented Oct 27, 2023

Copy link
Copy Markdown

Thanks @jonathanberthias for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 27, 2023
@jonathanberthias @miss-islington
Fix typos in import system docs (pythonGH-111396)
e6eac60 
(cherry picked from commit 9a2f2f4)

Co-authored-by: Jonathan Berthias <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 27, 2023

Copy link
Copy Markdown

GH-111397 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 27, 2023
AlexWaygood pushed a commit that referenced this pull request Oct 27, 2023
@miss-islington @jonathanberthias
[3.12] Fix typos in import system docs (GH-111396) (#111397)
2014c23 
Fix typos in import system docs (GH-111396)
(cherry picked from commit 9a2f2f4)

Co-authored-by: Jonathan Berthias <[email protected]>
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Oct 29, 2023
@jonathanberthias @iritkatriel
Fix typos in import system docs (python#111396)
c4b4583
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@jonathanberthias @aisk
Fix typos in import system docs (python#111396)
e89fb6d
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@jonathanberthias @Glyphack
Fix typos in import system docs (python#111396)
ad91bec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes
@Eclips4 Eclips4 Eclips4 approved these changes
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@jonathanberthias @AlexWaygood @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.