GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108765: Include explicitly <unistd.h> in signalmodule.c by vstinner · Pull Request #111402 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 27, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

unistd.h is needed by alarm() and pause().

  • Issue: C API: Cleanup header files #108765

📚 Documentation preview 📚: https://cpython-previews--111402.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@vstinner vstinner added the skip news label Oct 27, 2023
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 27, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 27, 2023
C API: Cleanup header files #108765
Closed
@vstinner vstinner mentioned this pull request Oct 27, 2023
gh-108765: Python.h no longer includes <unistd.h> #108783
Merged
@vstinner
pythongh-108765: Include explicitly <unistd.h> in signalmodule.c
98a8483 
unistd.h is needed by alarm() and pause().
@vstinner
vstinner force-pushed the signal_unistd branch from 4c83aa2 to 98a8483 Compare October 27, 2023 15:11
@vstinner
vstinner enabled auto-merge (squash) October 27, 2023 15:11
Eclips4
Eclips4 reviewed Oct 27, 2023
View reviewed changes
Comment thread Modules/signalmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner @Eclips4
Update Modules/signalmodule.c
638d9d3 
Co-authored-by: Kirill Podoprigora <[email protected]>
@vstinner

vstinner commented Oct 27, 2023

Copy link
Copy Markdown
Member Author

@Eclips4: Oops, I always forget about the test. I applied your suggestion.
Eclips4 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 77bb0d5 into python:main Oct 27, 2023
@vstinner
vstinner deleted the signal_unistd branch October 27, 2023 20:56
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 27, 2023
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Oct 29, 2023
@vstinner @iritkatriel
pythongh-108765: Include explicitly <unistd.h> in signalmodule.c (pyt…
64ca0a9 
…hon#111402)

unistd.h is needed by alarm() and pause() functions.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@vstinner @aisk
pythongh-108765: Include explicitly <unistd.h> in signalmodule.c (pyt…
221cbcd 
…hon#111402)

unistd.h is needed by alarm() and pause() functions.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-108765: Include explicitly <unistd.h> in signalmodule.c (pyt…
7784732 
…hon#111402)

unistd.h is needed by alarm() and pause() functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.