GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111374: Add a new PYTHON_FROZEN_MODULES env var, equivalent of `-X frozen_modules`. by yilei · Pull Request #111411 · python/cpython

Conversation

@yilei

@yilei yilei commented Oct 27, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

It seems that config_get_env can't distinguish between "not set" and "set to an empty string"? So PYTHON_FROZEN_MODULES= means differently than -X frozen_modules without values. I'm not sure if this could create confusion, but on the other hand the use of -X frozen_modules or -X frozen_modules= with empty values isn't explicitly documented.

  • Issue: Support configuring -X frozen_modules=on|off using an environment variable. #111374

📚 Documentation preview 📚: https://cpython-previews--111411.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
PYTHONDEVELOPER2007 reacted with eyes emoji
All reactions
  • 👀 1 reaction
yilei added 2 commits October 27, 2023 12:28
@yilei
Add a new PYTHONFROZENMODULES env var.
51f0845
@yilei
If the value is empty, turns out config_get_env returns NULL too.
0caabd0
@bedevere-app bedevere-app Bot mentioned this pull request Oct 27, 2023
Support configuring -X frozen_modules=on|off using an environment variable. #111374
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Oct 27, 2023
yilei added 2 commits October 27, 2023 13:45
@yilei
Fix the doc reference.
d79d11a
@yilei
Remove this test, it will use the default so it depends on how Python…
1d23236 
… is built.
gpshead
gpshead reviewed Oct 28, 2023
View reviewed changes
Comment thread Doc/using/cmdline.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@gpshead gpshead self-assigned this Oct 28, 2023
@yilei
Update to the new style.
af9834f
@hugovk hugovk changed the title gh-111374: Add a new PYTHONFROZENMODULES env var, equivalent of -X frozen_modules. gh-111374: Add a new PYTHON_FROZEN_MODULES env var, equivalent of -X frozen_modules. Oct 29, 2023
@hugovk

hugovk commented Oct 29, 2023

Copy link
Copy Markdown
Member

Please also add this to https://docs.python.org/3.13/whatsnew/3.13.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
yilei added 3 commits October 29, 2023 13:19
@yilei
Merge branch 'main' into frozen
91667ee
@yilei
Update 3.13.rst
866edde
@yilei
Reworded whats new to be consistent.
2b8b38b
hugovk
hugovk reviewed Oct 29, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs changes. Looks good, just some little nits.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Core and Builtins/2023-10-27-11-22-09.gh-issue-111374.e9lrPZ.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/using/cmdline.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
yilei and others added 4 commits October 29, 2023 17:04
@yilei @hugovk
Update Doc/whatsnew/3.13.rst
a0265a2 
Co-authored-by: Hugo van Kemenade <[email protected]>
@yilei @hugovk
Update Misc/NEWS.d/next/Core and Builtins/2023-10-27-11-22-09.gh-issu…
8836d28 
…e-111374.e9lrPZ.rst

Co-authored-by: Hugo van Kemenade <[email protected]>
@yilei @hugovk
Update Doc/using/cmdline.rst
d12e326 
Co-authored-by: Hugo van Kemenade <[email protected]>
@yilei
Also update the -X frozen_modules doc formatting.
4716773
@yilei

yilei commented Oct 30, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the review, -X frozen_modules is also updated. Please take another look.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@yilei
yilei requested a review from gpshead November 1, 2023 20:00
@gpshead
help text style change, align the :
964b69b
gpshead
gpshead approved these changes Nov 1, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 1, 2023
@gpshead
gpshead enabled auto-merge (squash) November 1, 2023 20:12
@gpshead
gpshead merged commit 45a36d5 into python:main Nov 1, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 1, 2023
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@yilei @hugovk @FullteaR
pythongh-111374: Add a new PYTHON_FROZEN_MODULES env var, equivalent …
2abb283 
…of `-X frozen_modules`. (python#111411)

Adds a new PYTHON_FROZEN_MODULES env var to correspond with -X frozen_modules.

Co-authored-by: Hugo van Kemenade <[email protected]>
@yilei
yilei deleted the frozen branch December 12, 2023 20:46
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@yilei @hugovk @aisk
pythongh-111374: Add a new PYTHON_FROZEN_MODULES env var, equivalent …
d2fd318 
…of `-X frozen_modules`. (python#111411)

Adds a new PYTHON_FROZEN_MODULES env var to correspond with -X frozen_modules.

Co-authored-by: Hugo van Kemenade <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@yilei @hugovk @Glyphack
pythongh-111374: Add a new PYTHON_FROZEN_MODULES env var, equivalent …
dac5adf 
…of `-X frozen_modules`. (python#111411)

Adds a new PYTHON_FROZEN_MODULES env var to correspond with -X frozen_modules.

Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@yilei @hugovk @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.