GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-66425: Remove the unreachable code to set `REMOTE_HOST` header by c-bata · Pull Request #111441 · python/cpython

Conversation

@c-bata

@c-bata c-bata commented Oct 29, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@corona10 Hi Donghee. Thank you for leading the CPython dev. sprint at PyCon APAC 2023. This patch does not contain additional test code because it only removes the unreachable lines; there are no changes in behavior.

Please refer to https://www.rfc-editor.org/rfc/rfc3875#page-16 about REMOTE_HOST header.

  • Issue: wsgiref doesn't appear to ever set REMOTE_HOST in the environ #66425

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@c-bata
pythongh-66425: Remove the unreachable code to set REMOTE_HOST header…
9c12d65 
… from wsgiref module
@ghost

ghost commented Oct 29, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Oct 29, 2023
wsgiref doesn't appear to ever set REMOTE_HOST in the environ #66425
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Oct 29, 2023
@corona10
corona10 self-requested a review October 29, 2023 04:21
corona10
corona10 approved these changes Oct 29, 2023
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Even if someone overrides WSGIRequestHandler there is the documentation that the user should care about: https://docs.python.org/3/library/wsgiref.html?highlight=wsgirequesthandler#wsgiref.simple_server.WSGIRequestHandler

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
c-bata reacted with heart emoji c-bata reacted with rocket emoji
All reactions
  • ❤️ 1 reaction
  • 🚀 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 29, 2023
@corona10
corona10 merged commit 8c47ada into python:main Oct 29, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 29, 2023
@c-bata
c-bata deleted the gh-66425 branch October 29, 2023 05:05
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Oct 29, 2023
@c-bata @iritkatriel
pythongh-66425: Remove the unreachable code to set REMOTE_HOST head…
31a9dcf 
…er (pythongh-111441)
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@c-bata @FullteaR
pythongh-66425: Remove the unreachable code to set REMOTE_HOST head…
ab530e0 
…er (pythongh-111441)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@c-bata @aisk
pythongh-66425: Remove the unreachable code to set REMOTE_HOST head…
67439d9 
…er (pythongh-111441)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@c-bata @Glyphack
pythongh-66425: Remove the unreachable code to set REMOTE_HOST head…
6c9ade5 
…er (pythongh-111441)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@c-bata @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.