GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111062: Separate macOS build into a reusable workflow by dimaqq · Pull Request #111444 · python/cpython

Conversation

@dimaqq

@dimaqq dimaqq commented Oct 29, 2023

Copy link
Copy Markdown
Contributor

gh-111062: Separate macOS build into a reusable workflow

For #111062, in order to run nogil build/tests, separate the build into a reusable workflow first.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dimaqq
Separate macOS build into a reusable workflow
d03ac6e 
For python#111062, in order to run nogil build/tests, separate the build into
a reusable workflow first.

syntax

pass config_hash along

one reusable per os

typos

typos

cleanup🧼

cleanup🧼
@dimaqq
dimaqq requested review from ezio-melotti and hugovk as code owners October 29, 2023 05:30
@bedevere-app bedevere-app Bot added the awaiting review label Oct 29, 2023
@corona10 corona10 changed the title Separate macOS build into a reusable workflow gh-111062: Separate macOS build into a reusable workflow Oct 29, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 29, 2023
Add GitHub Action for checking free-threaded build #111062
Closed
@corona10 corona10 self-assigned this Oct 29, 2023
@corona10 corona10 added the skip news label Oct 29, 2023
corona10
corona10 reviewed Oct 29, 2023
View reviewed changes
Comment thread .github/workflows/reusable-build-macos.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@dimaqq
hide the new job name
2021082
corona10
corona10 approved these changes Oct 29, 2023
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 29, 2023
@corona10
corona10 enabled auto-merge (squash) October 29, 2023 05:54
@corona10
corona10 merged commit 3ac9851 into python:main Oct 29, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 29, 2023
@dimaqq dimaqq mentioned this pull request Oct 29, 2023
wip: reusable workflows dimaqq/cpython#1
Closed
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Oct 29, 2023
@dimaqq @iritkatriel
pythongh-111062: Separate macOS build into a reusable workflow (pytho…
8d5134b 
…ngh-111444)
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@dimaqq @FullteaR
pythongh-111062: Separate macOS build into a reusable workflow (pytho…
05924a6 
…ngh-111444)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@dimaqq @aisk
pythongh-111062: Separate macOS build into a reusable workflow (pytho…
b1da640 
…ngh-111444)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@dimaqq @Glyphack
pythongh-111062: Separate macOS build into a reusable workflow (pytho…
6e2c6c8 
…ngh-111444)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@corona10 corona10

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@dimaqq @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.