GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94808: Add coverage test for number check by ekohilas · Pull Request #111445 · python/cpython

Conversation

@ekohilas

@ekohilas ekohilas commented Oct 29, 2023

Copy link
Copy Markdown
Contributor

Add coverage test for number check

gh-94808: Adds a coverage test for PyNumber_Check as part of #94808

Thanks to @corona10 for helping out!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ekohilas
Add aoverage test for number check
91daa4d
@ghost

ghost commented Oct 29, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label Oct 29, 2023
@bedevere-app

bedevere-app Bot commented Oct 29, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@blurb-it
📜🤖 Added by blurb_it.
08c5af9
@corona10 corona10 changed the title Add coverage test for number check gh-94808: Add coverage test for number check Oct 29, 2023
@corona10 corona10 added the skip issue label Oct 29, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 29, 2023
Metabug: Improving C-level coverage #94808
Open
@corona10 corona10 added skip news and removed skip issue labels Oct 29, 2023
@corona10 corona10 self-assigned this Oct 29, 2023
corona10
corona10 reviewed Oct 29, 2023
View reviewed changes
Comment thread Lib/test/test_capi/test_abstract.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
corona10
corona10 reviewed Oct 29, 2023
View reviewed changes
Comment thread Lib/test/test_capi/test_abstract.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
corona10
corona10 reviewed Oct 29, 2023
View reviewed changes
Comment thread Lib/test/test_capi/test_abstract.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
corona10
corona10 reviewed Oct 29, 2023
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to extend the test to test float, and integer too?
And also for false tests for 'str' or something other types?
Looks like there is no explicit test for this API :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ekohilas and others added 2 commits October 29, 2023 08:12
@ekohilas @corona10
Update Lib/test/test_capi/test_abstract.py
9baf417 
Co-authored-by: Donghee Na <[email protected]>
@ekohilas @corona10
Update Lib/test/test_capi/test_abstract.py
445bcc0 
Co-authored-by: Donghee Na <[email protected]>
corona10
corona10 reviewed Oct 29, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Tests/2023-10-29-05-41-47.gh-issue-94808.0FHZfr.rst Outdated
@@ -0,0 +1 @@
Add a C API test for the PyNumber_Check function.

@corona10 corona10 Oct 29, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please remove this file too :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ekohilas @corona10
Update Lib/test/test_capi/test_abstract.py
fd3d99c 
Co-authored-by: Donghee Na <[email protected]>
@ekohilas
ekohilas force-pushed the gh-94808 branch from 864c868 to fd3d99c Compare October 29, 2023 06:33
@ekohilas
ekohilas requested a review from corona10 October 29, 2023 06:33
corona10
corona10 approved these changes Oct 29, 2023
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 29, 2023
@corona10
corona10 enabled auto-merge (squash) October 29, 2023 06:41
@corona10
corona10 merged commit 842e5fc into python:main Oct 29, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 29, 2023
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Oct 29, 2023
@ekohilas @iritkatriel
pythongh-94808: Add coverage test for number check (pythongh-111445)
f2fc8ee
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@ekohilas @FullteaR
pythongh-94808: Add coverage test for number check (pythongh-111445)
55e150c
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@ekohilas @aisk
pythongh-94808: Add coverage test for number check (pythongh-111445)
9a981fd
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@ekohilas @Glyphack
pythongh-94808: Add coverage test for number check (pythongh-111445)
af287e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@corona10 corona10

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ekohilas @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.