GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-68166: Tkinter: Add tests and examples for element_create() by serhiy-storchaka · Pull Request #111453 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Oct 29, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Remove mention of "vsapi" element type from the documentation.
  • Add tests for element_create() and other ttk.Style methods.
  • Add examples for element_create() in the documentation.
  • Issue: ttk.Style.element_create using incorrect tk.call syntax #68166

📚 Documentation preview 📚: https://cpython-previews--111453.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka
pythongh-68166: Tkinter: Add tests and examples for element_create()
bcd8cf2
* Remove mention of "vsapi" element type from the documentation.
* Add tests for element_create() and other ttk.Style methods.
* Add examples for element_create() in the documentation.
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir docs Documentation in the Doc dir needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 29, 2023
@serhiy-storchaka
serhiy-storchaka requested a review from terryjreedy October 29, 2023 08:13
@bedevere-app bedevere-app Bot mentioned this pull request Oct 29, 2023
ttk.Style.element_create using incorrect tk.call syntax #68166
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 29, 2023
@serhiy-storchaka
serhiy-storchaka merged commit 005d1e8 into python:main Nov 8, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Nov 8, 2023
@miss-islington-app

miss-islington-app Bot commented Nov 8, 2023

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka
serhiy-storchaka deleted the test-ttk-style-element-create branch November 8, 2023 16:26
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 8, 2023
@serhiy-storchaka @miss-islington
pythongh-68166: Tkinter: Add tests and examples for element_create() (p…
7400be7
…ythonGH-111453)

* Remove mention of "vsapi" element type from the documentation.
* Add tests for element_create() and other ttk.Style methods.
* Add examples for element_create() in the documentation.
(cherry picked from commit 005d1e8)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Nov 8, 2023

Copy link
Copy Markdown

GH-111857 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 8, 2023
@serhiy-storchaka @miss-islington
pythongh-68166: Tkinter: Add tests and examples for element_create() (p…
26ad143
…ythonGH-111453)

* Remove mention of "vsapi" element type from the documentation.
* Add tests for element_create() and other ttk.Style methods.
* Add examples for element_create() in the documentation.
(cherry picked from commit 005d1e8)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Nov 8, 2023
@bedevere-app

bedevere-app Bot commented Nov 8, 2023

Copy link
Copy Markdown

GH-111858 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Nov 8, 2023
serhiy-storchaka added a commit that referenced this pull request Nov 27, 2023
@miss-islington @serhiy-storchaka
[3.11] gh-68166: Tkinter: Add tests and examples for element_create() (…
c3e5d0d
…GH-111453) (GH-111858)

* Remove mention of "vsapi" element type from the documentation.
* Add tests for element_create() and other ttk.Style methods.
* Add examples for element_create() in the documentation.

(cherry picked from commit 005d1e8)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Nov 27, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-68166: Tkinter: Add tests and examples for element_create() (…
1cb95cd
…GH-111453) (GH-111857)

* Remove mention of "vsapi" element type from the documentation.
* Add tests for element_create() and other ttk.Style methods.
* Add examples for element_create() in the documentation.
(cherry picked from commit 005d1e8)

Co-authored-by: Serhiy Storchaka <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-68166: Tkinter: Add tests and examples for element_create() (p…
c793996
…ythonGH-111453)

* Remove mention of "vsapi" element type from the documentation.
* Add tests for element_create() and other ttk.Style methods.
* Add examples for element_create() in the documentation.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka @Glyphack
pythongh-68166: Tkinter: Add tests and examples for element_create() (p…
d8a34d3
…ythonGH-111453)

* Remove mention of "vsapi" element type from the documentation.
* Add tests for element_create() and other ttk.Style methods.
* Add examples for element_create() in the documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.