GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-110481: Fix _Py_ThreadId for non-free-threaded mode by corona10 · Pull Request #111503 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Oct 30, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Implement biased reference counting in --disable-gil builds #110481

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
pythongh-110481: Fix build bot for free-threaded mode
8ef44ef
@corona10
corona10 requested a review from colesbury October 30, 2023 16:17
@corona10 corona10 added the topic-free-threading label Oct 30, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 30, 2023
Implement biased reference counting in --disable-gil builds #110481
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 30, 2023
@corona10 corona10 added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed awaiting core review labels Oct 30, 2023
@bedevere-bot

bedevere-bot commented Oct 30, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @corona10 for commit 8ef44ef 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 30, 2023
@corona10 corona10 added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Oct 30, 2023
@bedevere-bot

bedevere-bot commented Oct 30, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @corona10 for commit 8ef44ef 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 30, 2023
@corona10 corona10 closed this Oct 30, 2023
@corona10 corona10 reopened this Oct 30, 2023
@corona10 corona10 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 30, 2023
@bedevere-bot

bedevere-bot commented Oct 30, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @corona10 for commit 8ef44ef 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 30, 2023
@corona10 corona10 changed the title gh-110481: Fix build bot for free-threaded mode gh-110481: Fix build bot for non-free-threaded mode Oct 30, 2023
@corona10 corona10 mentioned this pull request Oct 30, 2023
gh-110481: Implement biased reference counting #110764
Merged
colesbury
colesbury approved these changes Oct 30, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 30, 2023
vstinner
vstinner reviewed Oct 30, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gh-110481: Fix build bot for non-free-threaded mode #111503

Please don't mention buildbot, but mention the fixed function: _Py_ThreadId().

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@corona10 corona10 changed the title gh-110481: Fix build bot for non-free-threaded mode gh-110481: Fix _Py_ThreadId for non-free-threaded mode Oct 30, 2023
@corona10

corona10 commented Oct 30, 2023

Copy link
Copy Markdown
Member Author

Please don't mention buildbot, but mention the fixed function: _Py_ThreadId().

Good! I updated the PR title too.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Oct 30, 2023

Copy link
Copy Markdown
Member

s390x RHEL7 LTO + PGO 3.x failed on PR #110764, but pass with this PR: so this PR fix the buildbot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Oct 30, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 30, 2023
@corona10
corona10 merged commit 55df2de into python:main Oct 30, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 30, 2023
@corona10
corona10 deleted the gh-110481-fix-build-bot branch October 30, 2023 17:16
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@corona10 @FullteaR
pythongh-110481: Fix _Py_ThreadId for non-free-threaded mode (pythong…
2efd0c7 
…h-111503)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@corona10 @aisk
pythongh-110481: Fix _Py_ThreadId for non-free-threaded mode (pythong…
7ce13c1 
…h-111503)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@corona10 @Glyphack
pythongh-110481: Fix _Py_ThreadId for non-free-threaded mode (pythong…
8a0a8b8 
…h-111503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@colesbury colesbury colesbury approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@corona10 @bedevere-bot @vstinner @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.