GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111062 CI: Update skip lists for resuable workflows by hugovk · Pull Request #111521 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Oct 30, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Add all the top-level jobs on the needs and allowed-skips lists, and add the build_*_free_threaded jobs on the allowed_failures list.

Rename build_win32, build_win_amd64 and build_win_arm64 to build_windows and build_windows_free_threaded in the skip/allow lists now they're in reusable workflows.

Here's a test build on my fork showing a docs-only build completing: hugovk#58

Compare #111509 which "failed" the "All required checks pass" check.

  • Issue: Add GitHub Action for checking free-threaded build #111062

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
CI: Update skip lists
b0d348a
@hugovk
hugovk requested a review from ezio-melotti as a code owner October 30, 2023 20:18
@bedevere-app bedevere-app Bot mentioned this pull request Oct 30, 2023
Add GitHub Action for checking free-threaded build #111062
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 30, 2023
@hugovk hugovk added the skip news label Oct 30, 2023
Eclips4
Eclips4 approved these changes Oct 30, 2023
View reviewed changes

@Eclips4 Eclips4 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@hugovk

hugovk commented Oct 30, 2023

Copy link
Copy Markdown
Member Author

@webknjaz How does this look?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Oct 30, 2023
gh-111062: Reusable Windows build that supports free-threaded mode as the conditional CI #111493
Merged
webknjaz
webknjaz approved these changes Oct 30, 2023
View reviewed changes

@webknjaz webknjaz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugovk this should do. Although, the pre-reusable workflow might've required less jobs, IIRC. Nevertheless, this state is probably what you want.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
willingc
willingc approved these changes Oct 31, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 31, 2023
corona10
corona10 approved these changes Oct 31, 2023
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@hugovk
hugovk merged commit 173d13b into python:main Oct 31, 2023
@hugovk
hugovk deleted the ci-update-skip-lists branch October 31, 2023 05:49
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 31, 2023
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@hugovk @FullteaR
pythongh-111062 CI: Update skip lists for resuable workflows (python#…
1350a83 
…111521)

CI: Update skip lists
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@hugovk @aisk
pythongh-111062 CI: Update skip lists for resuable workflows (python#…
3fb3960 
…111521)

CI: Update skip lists
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@hugovk @Glyphack
pythongh-111062 CI: Update skip lists for resuable workflows (python#…
6826967 
…111521)

CI: Update skip lists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz webknjaz approved these changes
@willingc willingc willingc approved these changes
@corona10 corona10 corona10 approved these changes
@Eclips4 Eclips4 Eclips4 approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@hugovk @webknjaz @willingc @corona10 @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.