GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-110697: Use CLOCK_RES in test_os.TimerfdTests by vstinner · Pull Request #111529 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 30, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

More TimerfdTests tests tolerate a difference of 1 ms in measured elapsed time.

  • Issue: test_os.TimerfdTests fails on FreeBSD 14 and 15: missing select.epoll() #110697

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-110697: Use CLOCK_RES_NS in test_os.TimerfdTests
a581f52 
More TimerfdTests tests tolerate a difference of 1 ms in measured
elapsed time.
@vstinner vstinner added the skip news label Oct 30, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 30, 2023
test_os.TimerfdTests fails on FreeBSD 14 and 15: missing select.epoll() #110697
Closed
@bedevere-app bedevere-app Bot added awaiting core review tests Tests in the Lib/test dir labels Oct 30, 2023
@vstinner

vstinner commented Oct 30, 2023

Copy link
Copy Markdown
Member Author

Example of recent test failure:

FAIL: test_timerfd_poll (test.test_os.TimerfdTests.test_timerfd_poll)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_os.py", line 4139, in test_timerfd_poll
    self.check_timerfd_poll(False)
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_os.py", line 4135, in check_timerfd_poll
    self.assertGreater(dt, total_time / sec_to_nsec)
AssertionError: 0.4996331359999999 not greater than 0.5

The difference is only around 0.3 ms.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner enabled auto-merge (squash) October 30, 2023 22:22
@vstinner
vstinner disabled auto-merge October 30, 2023 22:22
@vstinner
vstinner enabled auto-merge (squash) October 30, 2023 22:22
@vstinner vstinner mentioned this pull request Oct 30, 2023
gh-90815: Fix mimalloc atomic.h on Windows arm64 #111527
Merged
@vstinner vstinner changed the title gh-110697: Use CLOCK_RES_NS in test_os.TimerfdTests gh-110697: Use CLOCK_RES in test_os.TimerfdTests Oct 30, 2023
@vstinner
vstinner merged commit 7b153d1 into python:main Oct 30, 2023
@vstinner
vstinner deleted the timerfs_clock_res branch October 30, 2023 22:48
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 30, 2023
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@vstinner @FullteaR
pythongh-110697: Use CLOCK_RES in test_os.TimerfdTests (python#111529)
2933533 
More TimerfdTests tests tolerate a difference of 1 ms in measured
elapsed time.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@vstinner @aisk
pythongh-110697: Use CLOCK_RES in test_os.TimerfdTests (python#111529)
377f60c 
More TimerfdTests tests tolerate a difference of 1 ms in measured
elapsed time.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-110697: Use CLOCK_RES in test_os.TimerfdTests (python#111529)
0ef0b93 
More TimerfdTests tests tolerate a difference of 1 ms in measured
elapsed time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.