GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111201: A new Python REPL by pablogsal · Pull Request #111567 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Oct 31, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: A new Python REPL #111201

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Eclips4, jezdez, hugovk, neutrinoceros, danielhollas, tusharsadhwani, erlend-aasland, henryiii, soof-golan, furkanonder, and johnslavik reacted with rocket emoji
All reactions
  • 🚀 11 reactions
@bedevere-app bedevere-app Bot mentioned this pull request Oct 31, 2023
A new Python REPL #111201
Closed
7 tasks done
vstinner
vstinner reviewed Nov 1, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You add many env vars. Can you document them in Doc/using/cmdline.rst?

Usually, env var names start with PYTHON. Should the variables be renamed?

Also, Python ignores env var starting with PYTHON if sys.flags.ignore_environment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/_pyrepl/__main__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/_pyrepl/__main__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/_pyrepl/curses.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/pythonrun.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/_pyrepl/__main__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Nov 1, 2023
View reviewed changes
Comment thread Lib/_pyrepl/_minimal_curses.py
manually.

Note that there is also a built-in module _minimal_curses which will
hide this one if compiled in.

@vstinner vstinner Nov 1, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it part of this PR? If not, do you consider adding it or not?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JelleZijlstra JelleZijlstra May 4, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sounds like this comment was carried over from pypy but doesn't apply here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal

pablogsal commented Nov 1, 2023

Copy link
Copy Markdown
Member Author

@vstinner the PR is still draft, please wait until we mark it as finished before reviewing as most of this code may change
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal added 8 commits April 27, 2024 18:24
@pablogsal
pythongh-111201: A new Python REPL
2bf1505
@pablogsal
Clean some files
35d322e
@pablogsal
Fix history across sessions
4d2303b
@pablogsal
Fore fixes to history
7763c05
@pablogsal
Lukasz was wrong all along
e85d873
@pablogsal
Implement REPL commands and remove F1 for help (curses shows that scr…
842496e 
…ambled)
@pablogsal
Restore F1 for help
1417b9b
@pablogsal
Implement colored prompt
4c69853
@pablogsal
pablogsal force-pushed the pyrepl branch from 3278af9 to 4c69853 Compare April 27, 2024 17:27
pablogsal and others added 13 commits April 27, 2024 18:53
@pablogsal
WIP for paste mode
359407b
@ambv
Only execute PYTHONSTARTUP when asked (we do it in main.c anyway)
85a2b35
@pablogsal
Fixed coloring
05a8831
@pablogsal
Do not run commands if they are shadowed
c074ca6
@ambv
Move pager routines to _pyrepl, so we can use it in the REPL without …
9584b5b 
…importing too much
@ambv
Don't assume stupid paths or you will be tested against your stupid a…
d7ddebd 
…ssumptions
@ambv
<F2> shows history so you can copy it, <F3> is paste mode
2d24cd2
@pablogsal
Do not include REPL commands in history
fe1b3ac
@ambv
Add Blurb
e1abd39
@ambv
Reintroduce old names to fix pydoc tests
afbeaab
@pablogsal
Add some tests
aee9fcf
@pablogsal
Add moar tests
77db960
@pablogsal
Add moar tests
2a64680
@pablogsal
pablogsal force-pushed the pyrepl branch 3 times, most recently from c34adb8 to 702b59e Compare April 28, 2024 14:47
@pablogsal
Cleanup and refactor
5bced59
@pablogsal @hugovk
Apply suggestions from code review
058bc7f 
Co-authored-by: Hugo van Kemenade <[email protected]>
@pablogsal

pablogsal commented May 5, 2024

Copy link
Copy Markdown
Member Author

Please also add a What's New entry.

There is already one (Misc/NEWS.d/next/Core and Builtins/2024-04-28-00-41-17.gh-issue-111201.cQsh5U.rst)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal and others added 2 commits May 5, 2024 12:21
@pablogsal @JelleZijlstra
Update Lib/_pyrepl/_minimal_curses.py
7ac9af8 
Co-authored-by: Jelle Zijlstra <[email protected]>
@pablogsal
Use more specific exceptions
7422f1c
@pablogsal

pablogsal commented May 5, 2024

Copy link
Copy Markdown
Member Author

@hugovk @JelleZijlstra I have implemented your suggestions. If you have some time, do you mind reviewing again?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal requested review from JelleZijlstra, hugovk and vstinner May 5, 2024 10:26
hugovk
hugovk approved these changes May 5, 2024
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs changes look good.

One suggestion: this PR adds the main docs to the tutorial, we should probably add something to the reference, but this could be a followup.

Please also add a What's New entry.

There is already one (Misc/NEWS.d/next/Core and Builtins/2024-04-28-00-41-17.gh-issue-111201.cQsh5U.rst)

That's the changelog, this change definitely needs highlighting in https://docs.python.org/3.13/whatsnew/3.13.html but it can also be in a followup PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal and ambv reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 5, 2024
ambv added 2 commits May 5, 2024 17:11
@ambv
Use better error messages
d2de559
@ambv
Add to What's New
3053b39
ambv
ambv approved these changes May 5, 2024
View reviewed changes
@ambv
Forgot the PyPy attribution in "What's New"
149658b
cfbolz
cfbolz approved these changes May 5, 2024
View reviewed changes

@cfbolz cfbolz left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool to see this!

Just to check, was it intentional that you didn't port PyPy's _pyrepl tests? There's not a huge amount of tests there, admittedly.

I am philosophically a little bit worried that people will start using and relying on _pyrepl internal details, which are now slightly different between PyPy and CPython, right? This could lead to PyPy's life getting somewhat harder in this area. As usual, it's hard to stop people from doing that, of course.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/_pyrepl/reader.py
self.restore()
yield
finally:
for arg in ("msg", "ps1", "ps2", "ps3", "ps4", "paste_mode"):

@cfbolz cfbolz May 5, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is there a discrepancy between how prev_state is constructed (which uses fields(self) and how it is used in the finally block (listing the attributes explicitly)?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ambv ambv May 5, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It evolved into this, which you're right would now be cleaner to just reuse the list of fields.

I originally started with just dict(__dict__) but when I added typing with slots=True the __dict__ was gone so I modified it to use fields() instead.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hugovk
hugovk reviewed May 5, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ambv @hugovk
let's never talk about this
be2a0c9 
Co-authored-by: Hugo van Kemenade <[email protected]>
@ambv
ambv merged commit f27f8c7 into python:main May 5, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 5, 2024
@bedevere-bot

bedevere-bot commented May 5, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD 3.x has failed when building commit f27f8c7.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1223/builds/3012) and take a look at the build logs.
  4. Check if the failure is related to this commit (f27f8c7) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1223/builds/3012

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_push_without_key_in_keymap - test.test_pyrepl.TestUnivEventQueue.test_push_without_key_in_keymap
  • test_flush_buf - test.test_pyrepl.TestUnivEventQueue.test_flush_buf
  • test_push_with_key_in_keymap - test.test_pyrepl.TestUnivEventQueue.test_push_with_key_in_keymap
  • test_insert - test.test_pyrepl.TestUnivEventQueue.test_insert
  • test_get - test.test_pyrepl.TestUnivEventQueue.test_get
  • test_push_special_key - test.test_pyrepl.TestUnivEventQueue.test_push_special_key
  • test_empty - test.test_pyrepl.TestUnivEventQueue.test_empty
  • test_push_with_keymap_in_keymap - test.test_pyrepl.TestUnivEventQueue.test_push_with_keymap_in_keymap
  • test_push_with_keymap_in_keymap_and_escape - test.test_pyrepl.TestUnivEventQueue.test_push_with_keymap_in_keymap_and_escape
  • test_push_unrecognized_escape_sequence - test.test_pyrepl.TestUnivEventQueue.test_push_unrecognized_escape_sequence

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 643, in test_push_without_key_in_keymap
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 613, in test_empty
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 653, in test_push_with_keymap_in_keymap
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 668, in test_push_with_keymap_in_keymap_and_escape
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 633, in test_push_with_key_in_keymap
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 625, in test_insert
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 691, in test_push_unrecognized_escape_sequence
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 607, in test_get
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 682, in test_push_special_key
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/buildbot/buildarea/3.x.ware-freebsd/build/Lib/test/test_pyrepl.py", line 619, in test_flush_buf
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 5, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM Raspbian 3.x has failed when building commit f27f8c7.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/424/builds/7064) and take a look at the build logs.
  4. Check if the failure is related to this commit (f27f8c7) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/424/builds/7064

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_push_without_key_in_keymap - test.test_pyrepl.TestUnivEventQueue.test_push_without_key_in_keymap
  • test_flush_buf - test.test_pyrepl.TestUnivEventQueue.test_flush_buf
  • test_push_with_key_in_keymap - test.test_pyrepl.TestUnivEventQueue.test_push_with_key_in_keymap
  • test_insert - test.test_pyrepl.TestUnivEventQueue.test_insert
  • test_get - test.test_pyrepl.TestUnivEventQueue.test_get
  • test_push_special_key - test.test_pyrepl.TestUnivEventQueue.test_push_special_key
  • test_empty - test.test_pyrepl.TestUnivEventQueue.test_empty
  • test_push_with_keymap_in_keymap - test.test_pyrepl.TestUnivEventQueue.test_push_with_keymap_in_keymap
  • test_push_with_keymap_in_keymap_and_escape - test.test_pyrepl.TestUnivEventQueue.test_push_with_keymap_in_keymap_and_escape
  • test_push_unrecognized_escape_sequence - test.test_pyrepl.TestUnivEventQueue.test_push_unrecognized_escape_sequence

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 691, in test_push_unrecognized_escape_sequence
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 625, in test_insert
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 613, in test_empty
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 653, in test_push_with_keymap_in_keymap
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 607, in test_get
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 682, in test_push_special_key
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 643, in test_push_without_key_in_keymap
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 668, in test_push_with_keymap_in_keymap_and_escape
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 633, in test_push_with_key_in_keymap
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/3.x.gps-raspbian.nondebug/build/Lib/test/test_pyrepl.py", line 619, in test_flush_buf
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 5, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Debian Clang LTO + PGO 3.x has failed when building commit f27f8c7.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1084/builds/4264) and take a look at the build logs.
  4. Check if the failure is related to this commit (f27f8c7) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1084/builds/4264

Failed tests:

  • test_pyrepl

Failed subtests:

  • test_push_without_key_in_keymap - test.test_pyrepl.TestUnivEventQueue.test_push_without_key_in_keymap
  • test_flush_buf - test.test_pyrepl.TestUnivEventQueue.test_flush_buf
  • test_push_with_key_in_keymap - test.test_pyrepl.TestUnivEventQueue.test_push_with_key_in_keymap
  • test_insert - test.test_pyrepl.TestUnivEventQueue.test_insert
  • test_get - test.test_pyrepl.TestUnivEventQueue.test_get
  • test_push_special_key - test.test_pyrepl.TestUnivEventQueue.test_push_special_key
  • test_empty - test.test_pyrepl.TestUnivEventQueue.test_empty
  • test_push_with_keymap_in_keymap - test.test_pyrepl.TestUnivEventQueue.test_push_with_keymap_in_keymap
  • test_push_with_keymap_in_keymap_and_escape - test.test_pyrepl.TestUnivEventQueue.test_push_with_keymap_in_keymap_and_escape
  • test_push_unrecognized_escape_sequence - test.test_pyrepl.TestUnivEventQueue.test_push_unrecognized_escape_sequence

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 682, in test_push_special_key
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 613, in test_empty
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 625, in test_insert
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 691, in test_push_unrecognized_escape_sequence
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 668, in test_push_with_keymap_in_keymap_and_escape
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 619, in test_flush_buf
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 653, in test_push_with_keymap_in_keymap
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 643, in test_push_without_key_in_keymap
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 607, in test_get
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno


Traceback (most recent call last):
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/unittest/mock.py", line 1420, in patched
    return func(*newargs, **newkeywargs)
  File "/var/lib/buildbot/workers/arm64-clang/3.x.gps-arm64-debian.clang.lto-pgo/build/Lib/test/test_pyrepl.py", line 633, in test_push_with_key_in_keymap
    eq = EventQueue(sys.stdout.fileno(), "utf-8")
                    ~~~~~~~~~~~~~~~~~^^
io.UnsupportedOperation: fileno
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@pablogsal @ambv
@mgmacias95 @lysnikolaou @hugovk @JelleZijlstra @SonicField
pythongh-111201: A new Python REPL (pythonGH-111567)
f9a298b 
Co-authored-by: Łukasz Langa <[email protected]>
Co-authored-by: Marta Gómez Macías <[email protected]>
Co-authored-by: Lysandros Nikolaou <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
@zanieb zanieb mentioned this pull request May 22, 2024
Initial attempt at support for Python 3.13. astral-sh/python-build-standalone#264
Closed
@AlexWaygood AlexWaygood mentioned this pull request May 27, 2024
traceback: py313 updates python/typeshed#12032
Merged
@max-muoto max-muoto mentioned this pull request Jul 9, 2024
Pydoc 3.13 fixes python/typeshed#12305
Merged
@SnoopJ SnoopJ mentioned this pull request Sep 4, 2024
_pyrepl.input.KeymapTranslator tests for non-existent Unicode category #123682
Open
@donbarbos donbarbos mentioned this pull request Feb 7, 2025
Inconsistent imports styles in Lib/_pyrepl #129758
Closed
@pablogsal
pablogsal deleted the pyrepl branch September 24, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv approved these changes
@hugovk hugovk hugovk approved these changes
@cfbolz cfbolz cfbolz approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@vstinner vstinner Awaiting requested review from vstinner
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@pablogsal @bedevere-bot @ambv @cfbolz @vstinner @JelleZijlstra @hugovk @mgmacias95 @lysnikolaou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.