GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-76785: Return an "excinfo" Object From Interpreter.run() by ericsnowcurrently · Pull Request #111573 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Oct 31, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: [subinterpreters] PEP 554 implementation: add interpreters module #76785

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ericsnowcurrently ericsnowcurrently added the skip news label Oct 31, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 31, 2023
[subinterpreters] PEP 554 implementation: add interpreters module #76785
Closed
@ericsnowcurrently ericsnowcurrently changed the title gh-76785: Return an ExceptionSnapshot from Interpreter.run(). gh-76785: Return an ExceptionSnapshot From Interpreter.run() Oct 31, 2023
@ericsnowcurrently
ericsnowcurrently force-pushed the interp-run-return-exc-info branch 4 times, most recently from 5443e2c to 3f56dbf Compare November 2, 2023 16:18
@ericsnowcurrently ericsnowcurrently mentioned this pull request Nov 3, 2023
gh-76785: Move _Py_excinfo Functions Out of the Internal C-API #111715
Merged
@ericsnowcurrently
ericsnowcurrently force-pushed the interp-run-return-exc-info branch from 3f56dbf to f25d3f9 Compare November 3, 2023 22:36
ericsnowcurrently added a commit that referenced this pull request Nov 6, 2023
@ericsnowcurrently
gh-76785: Move _Py_excinfo Functions Out of the Internal C-API (gh-11…
d4426e8
…1715)

I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) in gh-111530 (9322ce9).  Since then I've had a nagging sense that I should have added the type and functions in its own PR.  While I do plan on using _Py_excinfo outside crossinterp.c very soon (see gh-111572/gh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR.  Hence, here we are.

(FWIW, I may combine that with gh-111572, which I may, in turn, combine with gh-111573.  We'll see.)
@ericsnowcurrently
ericsnowcurrently force-pushed the interp-run-return-exc-info branch from f25d3f9 to 9f83af7 Compare November 6, 2023 19:14
hugovk pushed a commit to hugovk/cpython that referenced this pull request Nov 8, 2023
@ericsnowcurrently @hugovk
pythongh-76785: Move _Py_excinfo Functions Out of the Internal C-API (p…
8ac1b5b
…ythongh-111715)

I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) in pythongh-111530 (9322ce9).  Since then I've had a nagging sense that I should have added the type and functions in its own PR.  While I do plan on using _Py_excinfo outside crossinterp.c very soon (see pythongh-111572/pythongh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR.  Hence, here we are.

(FWIW, I may combine that with pythongh-111572, which I may, in turn, combine with pythongh-111573.  We'll see.)
ericsnowcurrently added 4 commits November 22, 2023 15:35
@ericsnowcurrently
Add more type info to _PyXI_excinfo.
d93f584
@ericsnowcurrently
Return a excinfo object from _PyXI_ApplyError().
362412d
@ericsnowcurrently
Return an excinfo object from _interpreters.exec().
61845dd
@ericsnowcurrently
_interpreters.RunFailedError -> interpreters.RunFailedError
dfff3e3
@ericsnowcurrently
ericsnowcurrently force-pushed the interp-run-return-exc-info branch from 9f83af7 to dfff3e3 Compare November 23, 2023 00:33
@ericsnowcurrently ericsnowcurrently changed the title gh-76785: Return an ExceptionSnapshot From Interpreter.run() gh-76785: Return an "excinfo" Object From Interpreter.run() Nov 23, 2023
@ericsnowcurrently
ericsnowcurrently marked this pull request as ready for review November 23, 2023 00:48
@ericsnowcurrently
ericsnowcurrently requested review from brettcannon, ncoghlan and warsaw as code owners November 23, 2023 00:48
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 23, 2023
@ericsnowcurrently
ericsnowcurrently removed request for brettcannon, ncoghlan and warsaw November 23, 2023 00:48
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) November 23, 2023 00:48
@ericsnowcurrently
ericsnowcurrently merged commit 9e56eed into python:main Nov 23, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Nov 23, 2023
@ericsnowcurrently
ericsnowcurrently deleted the interp-run-return-exc-info branch November 23, 2023 00:55
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@ericsnowcurrently @aisk
pythongh-76785: Move _Py_excinfo Functions Out of the Internal C-API (p…
34fab73
…ythongh-111715)

I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) in pythongh-111530 (9322ce9).  Since then I've had a nagging sense that I should have added the type and functions in its own PR.  While I do plan on using _Py_excinfo outside crossinterp.c very soon (see pythongh-111572/pythongh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR.  Hence, here we are.

(FWIW, I may combine that with pythongh-111572, which I may, in turn, combine with pythongh-111573.  We'll see.)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@ericsnowcurrently @aisk
pythongh-76785: Return an "excinfo" Object From Interpreter.run() (py…
3a10f50
…thongh-111573)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@ericsnowcurrently @Glyphack
pythongh-76785: Move _Py_excinfo Functions Out of the Internal C-API (p…
049be32
…ythongh-111715)

I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) in pythongh-111530 (9322ce9).  Since then I've had a nagging sense that I should have added the type and functions in its own PR.  While I do plan on using _Py_excinfo outside crossinterp.c very soon (see pythongh-111572/pythongh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR.  Hence, here we are.

(FWIW, I may combine that with pythongh-111572, which I may, in turn, combine with pythongh-111573.  We'll see.)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@ericsnowcurrently @Glyphack
pythongh-76785: Return an "excinfo" Object From Interpreter.run() (py…
85f99b2
…thongh-111573)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.