GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-111089: Use PyUnicode_AsUTF8() in Argument Clinic by vstinner · Pull Request #111585 · python/cpython

Conversation

vstinner commented Nov 1, 2023 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Replace PyUnicode_AsUTF8AndSize() with PyUnicode_AsUTF8() to remove the explicit check for embedded null characters.

The change avoids to have to include explicitly <string.h> to get the strlen() function when using a recent version of the limited C API.

Issue: [C API] Change PyUnicode_AsUTF8() to return NULL on embedded null characters #111089

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-111089: Use PyUnicode_AsUTF8() in Argument Clinic

bd3942f

Replace PyUnicode_AsUTF8AndSize() with PyUnicode_AsUTF8() to remove
the explicit check for embedded null characters.

The change avoids to have to include explicitly <string.h> to get the
strlen() function when using a recent version of the limited C API.

vstinner requested review from AlexWaygood, berkerpeksag, corona10 and erlend-aasland as code owners

November 1, 2023 01:09

bedevere-app Bot mentioned this pull request

Nov 1, 2023

[C API] Change PyUnicode_AsUTF8() to return NULL on embedded null characters #111089

Closed

bedevere-app Bot added the awaiting core review label

Nov 1, 2023

vstinner added skip news and removed awaiting core review labels

Nov 1, 2023

erlend-aasland approved these changes

Nov 1, 2023

View reviewed changes

erlend-aasland left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Victor! I'm fine with this, but I'd like to get @serhiy-storchaka opinion too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added the awaiting merge label

Nov 1, 2023

erlend-aasland requested a review from serhiy-storchaka

November 1, 2023 14:13

AlexWaygood approved these changes

Nov 1, 2023

View reviewed changes

AlexWaygood left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka reviewed

Nov 1, 2023

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Do you mind to change also PyArg_Parse*?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka approved these changes

Nov 1, 2023

View reviewed changes

vstinner merged commit d9b606b into python:main

Nov 1, 2023

vstinner deleted the clinic_asutf8 branch

November 1, 2023 15:34

bedevere-app Bot removed the awaiting merge label

Nov 1, 2023

vstinner commented Nov 1, 2023

Copy link

Copy Markdown

Member Author

Merged, thanks for reviews.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner commented Nov 1, 2023

Copy link

Copy Markdown

Member Author

Do you mind to change also PyArg_Parse*?

Ok, I wrote PR #111620 for that.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

FullteaR pushed a commit to FullteaR/cpython that referenced this pull request

Nov 3, 2023


          pythongh-111089: Use PyUnicode_AsUTF8() in Argument Clinic (python#11…

484b325

…1585)

Replace PyUnicode_AsUTF8AndSize() with PyUnicode_AsUTF8() to remove
the explicit check for embedded null characters.

The change avoids to have to include explicitly <string.h> to get the
strlen() function when using a recent version of the limited C API.

vstinner added a commit to vstinner/cpython that referenced this pull request

Nov 7, 2023


          Revert "pythongh-111089: Use PyUnicode_AsUTF8() in Argument Clinic (p…

cba249d

…ython#111585)"

This reverts commit d9b606b.

vstinner mentioned this pull request

Nov 7, 2023

gh-111089: Revert PyUnicode_AsUTF8() changes #111833

Merged

vstinner added a commit that referenced this pull request

Nov 7, 2023


          gh-111089: Revert PyUnicode_AsUTF8() changes (#111833)

11e8348

* Revert "gh-111089: Use PyUnicode_AsUTF8() in Argument Clinic (#111585)"

This reverts commit d9b606b.

* Revert "gh-111089: Use PyUnicode_AsUTF8() in getargs.c (#111620)"

This reverts commit cde1071.

* Revert "gh-111089: PyUnicode_AsUTF8() now raises on embedded NUL (#111091)"

This reverts commit d731579.

* Revert "gh-111089: Add PyUnicode_AsUTF8() to the limited C API (#111121)"

This reverts commit d8f32be.

* Revert "gh-111089: Use PyUnicode_AsUTF8() in sqlite3 (#111122)"

This reverts commit 37e4e20.

hugovk pushed a commit to hugovk/cpython that referenced this pull request

Nov 8, 2023


          pythongh-111089: Revert PyUnicode_AsUTF8() changes (python#111833)

7fca996

* Revert "pythongh-111089: Use PyUnicode_AsUTF8() in Argument Clinic (python#111585)"

This reverts commit d9b606b.

* Revert "pythongh-111089: Use PyUnicode_AsUTF8() in getargs.c (python#111620)"

This reverts commit cde1071.

* Revert "pythongh-111089: PyUnicode_AsUTF8() now raises on embedded NUL (python#111091)"

This reverts commit d731579.

* Revert "pythongh-111089: Add PyUnicode_AsUTF8() to the limited C API (python#111121)"

This reverts commit d8f32be.

* Revert "pythongh-111089: Use PyUnicode_AsUTF8() in sqlite3 (python#111122)"

This reverts commit 37e4e20.

aisk pushed a commit to aisk/cpython that referenced this pull request

Feb 11, 2024


          pythongh-111089: Use PyUnicode_AsUTF8() in Argument Clinic (python#11…

5c79eca

…1585)

Replace PyUnicode_AsUTF8AndSize() with PyUnicode_AsUTF8() to remove
the explicit check for embedded null characters.

The change avoids to have to include explicitly <string.h> to get the
strlen() function when using a recent version of the limited C API.

aisk pushed a commit to aisk/cpython that referenced this pull request

Feb 11, 2024


          pythongh-111089: Revert PyUnicode_AsUTF8() changes (python#111833)

fce855e

* Revert "pythongh-111089: Use PyUnicode_AsUTF8() in Argument Clinic (python#111585)"

This reverts commit d9b606b.

* Revert "pythongh-111089: Use PyUnicode_AsUTF8() in getargs.c (python#111620)"

This reverts commit cde1071.

* Revert "pythongh-111089: PyUnicode_AsUTF8() now raises on embedded NUL (python#111091)"

This reverts commit d731579.

* Revert "pythongh-111089: Add PyUnicode_AsUTF8() to the limited C API (python#111121)"

This reverts commit d8f32be.

* Revert "pythongh-111089: Use PyUnicode_AsUTF8() in sqlite3 (python#111122)"

This reverts commit 37e4e20.

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024


          pythongh-111089: Use PyUnicode_AsUTF8() in Argument Clinic (python#11…

ef2e01b

…1585)

Replace PyUnicode_AsUTF8AndSize() with PyUnicode_AsUTF8() to remove
the explicit check for embedded null characters.

The change avoids to have to include explicitly <string.h> to get the
strlen() function when using a recent version of the limited C API.

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024


          pythongh-111089: Revert PyUnicode_AsUTF8() changes (python#111833)

455f5c7

* Revert "pythongh-111089: Use PyUnicode_AsUTF8() in Argument Clinic (python#111585)"

This reverts commit d9b606b.

* Revert "pythongh-111089: Use PyUnicode_AsUTF8() in getargs.c (python#111620)"

This reverts commit cde1071.

* Revert "pythongh-111089: PyUnicode_AsUTF8() now raises on embedded NUL (python#111091)"

This reverts commit d731579.

* Revert "pythongh-111089: Add PyUnicode_AsUTF8() to the limited C API (python#111121)"

This reverts commit d8f32be.

* Revert "pythongh-111089: Use PyUnicode_AsUTF8() in sqlite3 (python#111122)"

This reverts commit 37e4e20.

Reviewers

serhiy-storchaka

serhiy-storchaka approved these changes

erlend-aasland

erlend-aasland approved these changes

AlexWaygood

AlexWaygood approved these changes

corona10

Awaiting requested review from corona10

berkerpeksag

Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

vstinner commented Nov 1, 2023 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner commented Nov 1, 2023

Uh oh!

vstinner commented Nov 1, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vstinner commented Nov 1, 2023 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.