GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Simplify _PyPegen_join_names_with_dot() by serhiy-storchaka · Pull Request #111602 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Nov 1, 2023

Copy link
Copy Markdown
Member

It may also now be faster.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
Simplify _PyPegen_join_names_with_dot()
174f293
@serhiy-storchaka serhiy-storchaka added skip issue skip news labels Nov 1, 2023
@serhiy-storchaka
serhiy-storchaka requested review from lysnikolaou and pablogsal as code owners November 1, 2023 13:57
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 1, 2023
pablogsal
pablogsal approved these changes Nov 1, 2023
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @serhiy-storchaka 🖤

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 1, 2023
lysnikolaou
lysnikolaou approved these changes Nov 1, 2023
View reviewed changes
@serhiy-storchaka
serhiy-storchaka merged commit 937872e into python:main Nov 1, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 1, 2023
@serhiy-storchaka
serhiy-storchaka deleted the _PyPegen_join_names_with_dot branch November 1, 2023 14:25
@serhiy-storchaka

serhiy-storchaka commented Nov 1, 2023

Copy link
Copy Markdown
Member Author

Wow, with such fast response I will create more PRs for the parser.
lysnikolaou and erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka mentioned this pull request Nov 2, 2023
gh-111089: Add cache to PyUnicode_AsUTF8() for embedded NUL #111587
Closed
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@serhiy-storchaka @FullteaR
Simplify _PyPegen_join_names_with_dot() (pythonGH-111602)
aaedd28
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka @aisk
Simplify _PyPegen_join_names_with_dot() (pythonGH-111602)
d7402d4
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka @Glyphack
Simplify _PyPegen_join_names_with_dot() (pythonGH-111602)
6bf7ebe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou lysnikolaou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @pablogsal @lysnikolaou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.