GeezerVison is showing github.com — gh-108082: Remove _PyErr_WriteUnraisableMsg() by serhiy-storchaka · Pull Request #111643 · python/cpython
Conversation
serhiy-storchaka
commented
Nov 2, 2023
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Replace the remaining calls with PyErr_FormatUnraisable().
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Replace the remaining calls with PyErr_FormatUnraisable().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I only looked at C changes, I didn't review the tests changes.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
FullteaR
pushed a commit
to FullteaR/cpython
that referenced
this pull request
Nov 3, 2023
Replace the remaining calls with PyErr_FormatUnraisable().
vstinner
added a commit
to vstinner/cffi
that referenced
this pull request
Nov 15, 2023
Use the new public PyErr_FormatUnraisable() on Python 3.13.
The private _PyErr_WriteUnraisableMsg() function was removed in
Python 3.13:
python/cpython#111643
vstinner
added a commit
to vstinner/cffi
that referenced
this pull request
Nov 15, 2023
Use the new public PyErr_FormatUnraisable() on Python 3.13.
The private _PyErr_WriteUnraisableMsg() function was removed in
Python 3.13:
python/cpython#111643
|
cffi uses the private _PyErr_WriteUnraisableMsg() removed in Python 3.13. I wrote python-cffi/cffi#34 to update the code to the public PyErr_FormatUnraisable() function.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
vstinner
added a commit
to vstinner/cffi
that referenced
this pull request
Nov 15, 2023
Use the new public PyErr_FormatUnraisable() on Python 3.13.
The private _PyErr_WriteUnraisableMsg() function was removed in
Python 3.13:
python/cpython#111643
arigo
pushed a commit
to python-cffi/cffi
that referenced
this pull request
Nov 16, 2023
Use the new public PyErr_FormatUnraisable() on Python 3.13.
The private _PyErr_WriteUnraisableMsg() function was removed in
Python 3.13:
python/cpython#111643
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Replace the remaining calls with PyErr_FormatUnraisable().
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Replace the remaining calls with PyErr_FormatUnraisable().
Reviewers
vstinner
vstinner approved these changes
rhettinger
Awaiting requested review from rhettinger
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.