GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-111520: Add back the `operand` local by brandtbucher · Pull Request #111813 · python/cpython

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Nov 7, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

#111428 removed the operand local variable from the interpreter as part of a larger change. This adds it back, since the additional indirection makes tier two development more complicated.

  • Issue: Merge Tier 1 and 2 interpreters into a single function #111520

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brandtbucher
Add back the operand local
9388c90
@brandtbucher brandtbucher added performance Performance or resource usage skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Nov 7, 2023
@brandtbucher
brandtbucher requested a review from gvanrossum November 7, 2023 00:34
@brandtbucher brandtbucher self-assigned this Nov 7, 2023
@brandtbucher
brandtbucher requested a review from markshannon as a code owner November 7, 2023 00:34
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 7, 2023
@brandtbucher brandtbucher changed the title GH-11520: Add back the operand local GH-111520: Add back the operand local Nov 7, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Nov 7, 2023
Merge Tier 1 and 2 interpreters into a single function #111520
Closed
gvanrossum
gvanrossum reviewed Nov 7, 2023
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, but let's wait to see how this interacts with @mdboom's #111794 (fix for PGO on Windows).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brandtbucher reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@brandtbucher
Catch up with main
a29c9c5
@brandtbucher
brandtbucher merged commit 31ad7e0 into python:main Nov 14, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Nov 14, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@brandtbucher @aisk
pythonGH-111520: Add back the operand local (pythonGH-111813)
6e84a04
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@brandtbucher @Glyphack
pythonGH-111520: Add back the operand local (pythonGH-111813)
2567f3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum left review comments
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandtbucher brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@brandtbucher @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.