GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111460: restore ncurses widechar support on macOS by sorcio · Pull Request #111878 · python/cpython

Conversation

@sorcio

@sorcio sorcio commented Nov 9, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Ncurses wide character support on macOS was broken as an unintended consequence of #94452. It is now built as intended.

  • Issue: Restore ncurses widechar support on macOS #111460

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sorcio
pythongh-111460: restore ncurses widechar support on macOS
e1a1e32
@sorcio
sorcio requested review from corona10 and erlend-aasland as code owners November 9, 2023 12:00
@bedevere-app bedevere-app Bot added the awaiting review label Nov 9, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Nov 9, 2023
Restore ncurses widechar support on macOS #111460
Closed
@erlend-aasland

erlend-aasland commented Nov 10, 2023

Copy link
Copy Markdown
Contributor

Do you have the bandwidth to review this, @corona10?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented Nov 10, 2023

Copy link
Copy Markdown
Member

This weekend I will try :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 added the needs backport to 3.12 only security fixes label Nov 13, 2023
corona10
corona10 approved these changes Nov 13, 2023
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

I checked that what kinds of value $have_curses can have from source codes

cpython/configure.ac

Lines 6255 to 6271 in e1a1e32

AS_VAR_IF([ac_cv_header_ncurses_h], [yes], [
if test "$ac_sys_system" != "Darwin"; then
dnl On macOS, there is no separate /usr/lib/libncursesw nor libpanelw.
PKG_CHECK_MODULES([CURSES], [ncursesw], [
AC_DEFINE([HAVE_NCURSESW], [1])
have_curses=ncursesw
], [
WITH_SAVE_ENV([
AC_CHECK_LIB([ncursesw], [initscr], [
AC_DEFINE([HAVE_NCURSESW], [1])
have_curses=ncursesw
CURSES_CFLAGS=${CURSES_CFLAGS-""}
CURSES_LIBS=${CURSES_LIBS-"-lncursesw"}
])
])
])
fi

Thanks for catching this.
This PR should be backported

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 13, 2023
@corona10
corona10 merged commit d2f305d into python:main Nov 13, 2023
@miss-islington-app

miss-islington-app Bot commented Nov 13, 2023

Copy link
Copy Markdown

Thanks @sorcio for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 13, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 13, 2023
@sorcio @miss-islington
pythongh-111460: Restore ncurses widechar support on macOS (pythonGH-…
7f106a6 
…111878)

(cherry picked from commit d2f305d)

Co-authored-by: Davide Rizzo <[email protected]>
@bedevere-app

bedevere-app Bot commented Nov 13, 2023

Copy link
Copy Markdown

GH-112034 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Nov 13, 2023
corona10 pushed a commit that referenced this pull request Nov 14, 2023
@miss-islington @sorcio
[3.12] gh-111460: Restore ncurses widechar support on macOS (GH-111878)…
d34650e 
… (gh-112034)

gh-111460: Restore ncurses widechar support on macOS (GH-111878)
(cherry picked from commit d2f305d)

Co-authored-by: Davide Rizzo <[email protected]>
@sorcio
sorcio deleted the macos-restore-ncursesw branch November 14, 2023 16:55
@Turakar

Turakar commented Jan 17, 2024

Copy link
Copy Markdown

Might it be that a similar fix needs to be applied to the following line:

cpython/configure.ac

Line 6265 in f497525

if test "$ac_sys_system" != "Darwin"; then

It seems to me like this check is equally broken.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jan 17, 2024

Copy link
Copy Markdown
Contributor

Might it be that a similar fix needs to be applied to the following line:

cpython/configure.ac

Line 6265 in f497525

if test "$ac_sys_system" != "Darwin"; then

It seems to me like this check is equally broken.

Please open a new issue for this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sorcio @aisk
pythongh-111460: Restore ncurses widechar support on macOS (python#11…
1a9c29e 
…1878)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sorcio @Glyphack
pythongh-111460: Restore ncurses widechar support on macOS (python#11…
63654b4 
…1878)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sorcio @erlend-aasland @corona10 @Turakar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.