GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-111933: fix broken link to A.Neumaier article by skirpichev · Pull Request #111937 · python/cpython

Conversation

skirpichev commented Nov 10, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

It seems there are links to the archive.org in comments across the codebase. So, I hope it's fine.

Alternatively, we could point to the journal page: https://doi.org/10.1002/zamm.19740540106 (not open access, however). Or just add a citation (Neumaier, A. (1974), Rundungsfehleranalyse einiger Verfahren zur Summation endlicher Summen. Z. angew. Math. Mech., 54: 39-51.).

Issue: broken link to A.Neumaier article in built-in sum comment #111933

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-111933: fix broken link to A.Neumaier article

f2a7a57

bedevere-app Bot added the awaiting review label

Nov 10, 2023

bedevere-app Bot mentioned this pull request

Nov 10, 2023

broken link to A.Neumaier article in built-in sum comment #111933

Closed

skirpichev commented Nov 10, 2023

Copy link

Copy Markdown

Member Author

CC @rhettinger

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood added the skip news label

Nov 10, 2023

JelleZijlstra commented Nov 10, 2023

Copy link

Copy Markdown

Member

I would prefer adding the DOI and the full citation to the comment. It's better to have more ways to find the article for those interested.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

skirpichev commented

Nov 10, 2023

View reviewed changes

Comment thread

Python/bltinmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

rhettinger approved these changes

Nov 10, 2023

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels

Nov 10, 2023

skirpichev and others added 2 commits

November 11, 2023 05:29


          Update Python/bltinmodule.c

652be90

Co-authored-by: Jelle Zijlstra <[email protected]>


          Minor reformatting & replace archive.org with a link to prof Neumaier…

ed85ed9

… homepage

skirpichev commented Nov 11, 2023

Copy link

Copy Markdown

Member Author

I've commited @JelleZijlstra suggestion above, but archive.org link was replaces with url to the prof.Neumaier homepage (https://arnold-neumaier.at/scan/01.pdf), thanks to @pochmann.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

skirpichev requested a review from JelleZijlstra

November 11, 2023 02:40

rhettinger added the 3.12 only security fixes label

Nov 11, 2023


          Merge branch 'main' into fix-sum-link

1e97bc4

terryjreedy commented Nov 11, 2023

Copy link

Copy Markdown

Member

How about adding 'https://en.wikipedia.org/wiki/2Sum'? For me, it is a more useful link than the noisy image of German text, which as an image cannot be put into a translator.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

skirpichev commented Nov 11, 2023

Copy link

Copy Markdown

Member Author

How about adding 'https://en.wikipedia.org/wiki/2Sum'?

Then, maybe
https://en.wikipedia.org/wiki/Kahan_summation_algorithm#Further_enhancements
? It has relevant pseudocode and also a link (broken) to scanned text.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk added the needs backport to 3.12 only security fixes label

Nov 11, 2023

skirpichev commented

Nov 11, 2023

View reviewed changes

Comment thread

Python/bltinmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

rhettinger and others added 2 commits

November 11, 2023 17:45


          Switch to wikipedia link.

09ebdf7

Co-authored-by: Sergey B Kirpichev <[email protected]>


          Merge branch 'main' into fix-sum-link

34ccf26

rhettinger merged commit 12a30bc into python:main

Nov 12, 2023

miss-islington-app Bot commented Nov 12, 2023

Copy link

Copy Markdown

Thanks @skirpichev for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Nov 12, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 12, 2023


          pythongh-111933: fix broken link to A.Neumaier article (pythongh-111937)

ef741f8

(cherry picked from commit 12a30bc)

Co-authored-by: Sergey B Kirpichev <[email protected]>

bedevere-app Bot commented Nov 12, 2023

Copy link

Copy Markdown

GH-111993 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Nov 12, 2023

rhettinger pushed a commit that referenced this pull request

Nov 12, 2023


          [3.12] gh-111933: fix broken link to A.Neumaier article (gh-111937) (g…

158a7e1

…h-111993)

skirpichev deleted the fix-sum-link branch

November 12, 2023 02:20

aisk pushed a commit to aisk/cpython that referenced this pull request

Feb 11, 2024


          pythongh-111933: fix broken link to A.Neumaier article (pythongh-111937)

56272a8

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024


          pythongh-111933: fix broken link to A.Neumaier article (pythongh-111937)

23af8ce

Reviewers

rhettinger

rhettinger approved these changes

JelleZijlstra

Awaiting requested review from JelleZijlstra

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.12

only security fixes

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

skirpichev commented Nov 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skirpichev commented Nov 10, 2023

Uh oh!

JelleZijlstra commented Nov 10, 2023

Uh oh!

Uh oh!

skirpichev commented Nov 11, 2023

Uh oh!

terryjreedy commented Nov 11, 2023

Uh oh!

skirpichev commented Nov 11, 2023

Uh oh!

Uh oh!

miss-islington-app Bot commented Nov 12, 2023

Uh oh!

bedevere-app Bot commented Nov 12, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

skirpichev commented Nov 10, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.