GeezerVison

Original file line number	Diff line number	Diff line change
Expand Up		@@ -406,9 +406,12 @@ async def start_tls(self, sslcontext, *,

		def __del__(self, warnings=warnings):
		if not self._transport.is_closing():
		self.close()
		warnings.warn(f"unclosed {self!r}", ResourceWarning)

		try:
		self.close()
		except RuntimeError:
Comment thread Outdated gvanrossum Nov 13, 2023 Copy link Copy Markdown Member There was a problem hiding this comment. Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Catching all `RuntimeError`s always feels scary -- it could mark other, more serious bugs. How about only issuing the new warning if `self._loop.is_closed()`? Sorry, something went wrong. Uh oh! There was an error while loading. Please reload this page. dpr-0 and willingc reacted with thumbs up emoji All reactions 👍 2 reactions
		warnings.warn("loop is closed", ResourceWarning)
		else:
		warnings.warn(f"unclosed {self!r}", ResourceWarning)

		class StreamReader:

Expand Down

1 change: 1 addition & 0 deletions 1 Misc/NEWS.d/next/Library/2023-11-11-16-42-48.gh-issue-109538.cMG5ux.rst

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Issue warning message instead of having :class:`RuntimeError` be displayed when event loop has already been closed at :meth:`StreamWriter.__del__`.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

gh-109538: Catch closed loop runtime error and issue warning #111983

Uh oh!

gh-109538: Catch closed loop runtime error and issue warning #111983

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

gvanrossum Nov 13, 2023

Choose a reason for hiding this comment

Uh oh!