GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-28929: Add to Misc/NEWS by Mariatta · Pull Request #112 · python/cpython

Conversation

@Mariatta

@Mariatta Mariatta commented Feb 15, 2017

Copy link
Copy Markdown
Member

Mention bpo-28929 in the Documentation section of:

  • What's New in Python 3.7.0 alpha 1?
  • What's New in Python 3.6.1 release candidate 1?
  • What's New in Python 3.5.4 release candidate 1?

http://bugs.python.org/issue28929

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Mariatta
bpo-28929: Add to Misc/NEWS
8ebad41 
mention bpo-28929 in the Documentation section of:
- What's New in Python 3.7.0 alpha 1?
- What's New in Python 3.6.1 release candidate 1?
- What's New in Python 3.5.4 release candidate 1?

http://bugs.python.org/issue28929
@Mariatta Mariatta added needs backport to 2.7 labels Feb 15, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 15, 2017
@Mariatta
clean up
dd19eb2
@vstinner vstinner added the docs Documentation in the Doc dir label Feb 15, 2017
brettcannon
brettcannon requested changes Feb 15, 2017
View reviewed changes

@brettcannon brettcannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically don't worry about covering NEWS entries more than once in a single copy of the file since it's redundant information at that point; as long as someone reading the release notes in a release can see the news entry somewhere then that's enough.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS Outdated
Documentation
-------------

- bpo-28929: Link the documentation to its source file on GitHub

@brettcannon brettcannon Feb 15, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a period.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS Outdated
Documentation
-------------

- bpo-28929: Link the documentation to its source file on GitHub

@brettcannon brettcannon Feb 15, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecessary as the same bit of information is picked up in the 3.7 release notes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS Outdated
instead of TypeError on programmical error in parsing format string.


What's New in Python 3.5.4 release candidate 1?

@brettcannon brettcannon Feb 15, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also unnecessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Mariatta
Remove unecessary entries
f6ba012
@Mariatta

Mariatta commented Feb 16, 2017

Copy link
Copy Markdown
Member Author

Thanks @brettcannon :)
I removed the unnecessary entries.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta Mariatta removed needs backport to 2.7 labels Feb 16, 2017
@Mariatta

Mariatta commented Feb 16, 2017

Copy link
Copy Markdown
Member Author

I suppose it doesn't need backport then. But please re-add the labels if I'm mistaken.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon

brettcannon commented Feb 16, 2017

Copy link
Copy Markdown
Member

You can still backport into the appropriate sections, I'm just saying you don't need it more than once in the file at any one time.

And I'm now on vacation so I'll let someone else approve. 😀
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta Mariatta added needs backport to 2.7 labels Feb 16, 2017
@Mariatta

Mariatta commented Feb 16, 2017

Copy link
Copy Markdown
Member Author

Ah ok I think I got it now 😅 Re-added the backport labels.

Please enjoy your vacation!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brettcannon
brettcannon approved these changes Feb 24, 2017
View reviewed changes
@Mariatta
Merge branch 'master' into bpo-28929-news-master
d1213dc
@Mariatta
Mariatta merged commit e3bf4cd into python:master Feb 25, 2017
@Mariatta
Mariatta deleted the bpo-28929-news-master branch February 25, 2017 02:09
This was referenced Feb 25, 2017
[3.6] bpo-28929: Add to Misc/NEWS #284
Merged
[3.5] bpo-28929: Add to Misc/NEWS #285
Merged
[2.7] bpo-28929: Add to Misc/NEWS #286
Merged
@Mariatta Mariatta removed needs backport to 2.7 labels Feb 25, 2017
akruis referenced this pull request in stackless-dev/stackless Sep 5, 2017
Anselm Kruis
Issue #112: Prepare Stackless 3.5, fix a C-Python test suite bug
70d307e 
This commit merges the fix from C-Python pull request
python#1066 (git commit 22e032a) for
bpo-30028. Without this change
   $ ./python -m test.regrtest test_multiprocessing_fork
fails. ($ ./python -m test.test_multiprocessing_fork is OK.)

https://bitbucket.org/stackless-dev/stackless/issues/112
akruis referenced this pull request in stackless-dev/stackless Sep 5, 2017
Anselm Kruis
Issue #112: Prepare Stackless 3.5, fix test_dictviews, test_generator…
bf6be12 
…s and test_xml_etree

Disable the recently added test methods test_copy() and test_pickle() in test_dictviews, test_generators and test_xml_etree. Theses test assure that objects can't be copied or pickled, but Stackless can copy/pickle them.

https://bitbucket.org/stackless-dev/stackless/issues/112
akruis referenced this pull request in stackless-dev/stackless Sep 5, 2017
Anselm Kruis
Issue #112: Prepare Stackless 3.5, fix test_pdb.test_pdb_issue_20766
ec4105e 
Fix the recently added test test_pdb.test_pdb_issue_20766.
This test depends on undefined behaviour of C-Python (invalid value of
frame.f_lineno if frame.f_trace is None). Stackless-Python behaves differently,
if soft-switching is enabled. This change disables soft-switching for this
test.

https://bitbucket.org/stackless-dev/stackless/issues/112
akruis referenced this pull request in stackless-dev/stackless Sep 5, 2017
Anselm Kruis
Issue #112: Prepare Stackless 3.5, re-enable aggressive optimisation …
cbd6e7a 
…in ceval.c

#define PY_LOCAL_AGGRESSIVE in ceval.c. Commit c3815b2f9943 undefined it by accident.

https://bitbucket.org/stackless-dev/stackless/issues/112
akruis referenced this pull request in stackless-dev/stackless Sep 5, 2017
Anselm Kruis
Issue #112: Prepare Stackless 3.5, enable pickling of coroutines
60bbffd 
Coroutines are a new feature of Python 3.5. Because their implementation is based on generators, we can pickle and unpickle them easily.

https://bitbucket.org/stackless-dev/stackless/issues/112
akruis referenced this pull request in stackless-dev/stackless Sep 5, 2017
Anselm Kruis
Issue #112: Prepare Stackless 3.5, enable pickling of coroutines
bd76867 
Skip CPython test cases for coroutine pickling / copying.

https://bitbucket.org/stackless-dev/stackless/issues/112
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Anselm Kruis
Issue python#112: Prepare Stackless 3.5
6468d62 
-  Preserve the new generator attributes __qualname__ and __name__ on pickling

https://bitbucket.org/stackless-dev/stackless/issues/112
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Anselm Kruis
Issue python#112: Prepare Stackless 3.5
eef9b0e 
-  Skip the CPython test case test.test_pickle.*.test_local_lookup_error. This test checks, that pickling of a local function raises an exception. Stackless pickles the function by value.

https://bitbucket.org/stackless-dev/stackless/issues/112
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Anselm Kruis
Issue python#112: Prepare Stackless 3.5, fix pickling tests
85ae549 
-  Fix the CPython test case test.test_pickle.CompatPickleTests.test_exceptions

https://bitbucket.org/stackless-dev/stackless/issues/112
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Anselm Kruis
Issue python#112: Prepare Stackless 3.5, fix C-pickle for functions
29aa78a 
-  If C-pickle encounters a local function, save_global() now raises AttributeError instead of the documented PicklingError. This commits adapts the Stackless patch to kick in on AttributeError too.

https://bitbucket.org/stackless-dev/stackless/issues/112
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Anselm Kruis
Issue python#112: Prepare Stackless 3.5, fix PEP479 for Stackless gen…
d834451 
…erators

Stackless has its own copy of the gen_send_ex function: slp_gen_send_ex() and gen_iternext_callback(). I added the PEP479 code to gen_iternext_callback().

https://bitbucket.org/stackless-dev/stackless/issues/112
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Anselm Kruis
Issue python#112: Prepare Stackless 3.5, fix PEP492 for Stackless
1c7ff3e 
Fix various issues introduced by merging the PEP 492 implementation from default.

https://bitbucket.org/stackless-dev/stackless/issues/112
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Anselm Kruis
Issue python#112: Prepare Stackless 3.5, fix the reference counting
514d510 
Fix the reference counting in the slp_eval_frame_with_cleanup
code path. It was broken by commit e39fd5a8501a.

https://bitbucket.org/stackless-dev/stackless/issues/112
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Anselm Kruis
Issue python#112: Prepare Stackless 3.5, fix StopIteration from gener…
8243dfa 
…ators

Fix the handling of StopIteration raised from generators.
It was broken by commit 2771a0ac806b.

https://bitbucket.org/stackless-dev/stackless/issues/112
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Anselm Kruis
Issue python#112: Prepare Stackless 3.5, fix a C-Python test suite bug
ca52f72 
This commit merges the fix from C-Python pull request
python#1066 (git commit 22e032a) for
bpo-30028. Without this change
   $ ./python -m test.regrtest test_multiprocessing_fork
fails. ($ ./python -m test.test_multiprocessing_fork is OK.)

https://bitbucket.org/stackless-dev/stackless/issues/112
(grafted from bda8a9d487da7cfbe4357d5c4c7635e0de19c6af)
akruis pushed a commit to akruis/cpython that referenced this pull request Oct 10, 2017
Anselm Kruis
Merge branch 3.5-slp into master-slp (issue python#112 test suite fix)
814a94c
akruis pushed a commit to akruis/cpython that referenced this pull request Oct 10, 2017
Anselm Kruis
merge 3.5-slp (Stackless python#112, fix pickle/copy tests)
f95329c
akruis pushed a commit to akruis/cpython that referenced this pull request Nov 7, 2017
Anselm Kruis
merge 3.5-slp (Stackless issue python#112: enable pickling of corouti…
be5b7fb 
…nes)
akruis pushed a commit to akruis/cpython that referenced this pull request Nov 7, 2017
Anselm Kruis
Issue python#112: adapt the new msi installer to Stackless Python
9bcd2d1 
- Change the product and file names to Stackless (Python).
- Add Stackless include files
- Update the Product and Download URLs

(cherry picked from commit 0c1f53c)
akruis pushed a commit to akruis/cpython that referenced this pull request Mar 25, 2018
Anselm Kruis
merge 3.6-slp (Stackless issue python#112: enable pickling of corouti…
80865f2 
…nes)
akruis pushed a commit to akruis/cpython that referenced this pull request Mar 25, 2018
Anselm Kruis
Issue python#112: adapt the new msi installer to Stackless Python
0c1f53c 
- Change the product and file names to Stackless (Python).
- Add Stackless include files
- Update the Product and Download URLs
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@Mariatta
Don't merge PR unless it has "awaiting merge" label (#112)
8fe9d1f 
Change the behavior for when deciding when miss-islington
should merge the PR.

Previously it checks if the PR has one core dev who approved the PR.
But that is unreliable because the review may be dismissed later,
or another core dev might decide not to backport the PR anymore.

The "awaiting merge" label is a better indicator that the PR
is ready for merge.

Adjust tests.

Fixes python/miss-islington#62
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
heap-use-after-free in _PyFunction_LookupByVersion #108253
Closed
@ngoldbaum ngoldbaum mentioned this pull request Sep 23, 2024
Crash running PyO3 tests with --test-threads=1000 #124375
Closed
This was referenced Feb 11, 2025
segmentfault when pip installing setuptools #129992
Closed
segmentfault when pip installing setuptools #129993
Closed
@sergey-miryanov sergey-miryanov mentioned this pull request Dec 18, 2025
Observed memory leak in ssl library: Python 3.14 GC issue #142516
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Mariatta @brettcannon @vstinner @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.