GeezerVison is showing github.com — gh-111856: fix os.fstat on windows with fat32 and exfat filesystem by aisk · Pull Request #112038 · python/cpython
Conversation
aisk
commented
Nov 13, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
The change is just like #104892.
I think this is hard to test this on GHA, since it needs a disk with fat32 or exfat filesystem. I made a test on my local machine, the drive "E://" is a fat32 filesystem.
Test codes:
import os
f = open("e://a.jpg")
print(os.stat(f.fileno()))
f.close()
Before the comit:
C:\Users\xxxxx\Source\cpython>python a.py
Running Debug|x64 interpreter...
Traceback (most recent call last):
File "C:\Users\xxxxx\Source\cpython\a.py", line 4, in <module>
print(os.stat(f.fileno()))
^^^^^^^^^^^^^^^^^^^
OSError: [WinError 87] 参数错误。: 3
sys:1: ResourceWarning: unclosed file <_io.TextIOWrapper name='e://a.jpg' mode='r' encoding='cp936'>
After the commit:
C:\Users\xxxxx\Source\cpython>python a.py
Running Debug|x64 interpreter...
os.stat_result(st_mode=33206, st_ino=4194592, st_dev=1548577950, st_nlink=1, st_uid=0, st_gid=0, st_size=2812450, st_atime=1699718400, st_mtime=1673715360, st_ctime=-11644473600)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks @aisk for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
aisk
added a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|