GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108303: Move `double_const` to `test_import` where it belongs by sobolevn · Pull Request #112108 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Nov 15, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I think that initial PR just forgot about it :)

  • Issue: Move test files into test subdirectories #108303

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-108303: Move double_const to test_import where it belongs
106c268
@sobolevn
sobolevn requested a review from vstinner November 15, 2023 07:14
@sobolevn
sobolevn requested review from brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners November 15, 2023 07:14
@bedevere-app bedevere-app Bot added the awaiting review label Nov 15, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Nov 15, 2023
Move test files into test subdirectories #108303
Closed
@sobolevn sobolevn added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Nov 15, 2023
vstinner
vstinner reviewed Nov 15, 2023
View reviewed changes
Comment thread Lib/test/test_import/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Address review
23319d9
vstinner
vstinner reviewed Nov 15, 2023
View reviewed changes
Comment thread Lib/test/test_import/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Simplify import
0af9fb6
brettcannon
brettcannon reviewed Nov 15, 2023
View reviewed changes
Comment thread Lib/test/test_import/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
brettcannon
brettcannon previously requested changes Nov 17, 2023
View reviewed changes
Comment thread Lib/test/test_import/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting review labels Nov 17, 2023
@bedevere-app

bedevere-app Bot commented Nov 17, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Update __init__.py
80be93a
vstinner
vstinner reviewed Nov 30, 2023
View reviewed changes
Comment thread Lib/test/test_import/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
sobolevn added 2 commits December 2, 2023 13:00
@sobolevn
Address review
6d5b4f7
@sobolevn
Merge branch 'issue-108303-test_import' of https://github.com/sobolev…
962093b 
…n/cpython into issue-108303-test_import
@sobolevn

sobolevn commented Dec 10, 2023

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Dec 11, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting changes labels Dec 11, 2023
@vstinner
vstinner dismissed brettcannon’s stale review December 11, 2023 18:29

TEST_HOME_DIR is no longer imported.

@vstinner
vstinner merged commit 0738b9a into python:main Dec 11, 2023
@miss-islington-app

miss-islington-app Bot commented Dec 11, 2023

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 11, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2023
@sobolevn @miss-islington
pythongh-108303: Move double_const to test_import where it belongs (
352cb98 
pythonGH-112108)

(cherry picked from commit 0738b9a)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app

bedevere-app Bot commented Dec 11, 2023

Copy link
Copy Markdown

GH-112976 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Dec 11, 2023
@bedevere-app

bedevere-app Bot commented Dec 11, 2023

Copy link
Copy Markdown

GH-112977 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2023
@sobolevn @miss-islington
pythongh-108303: Move double_const to test_import where it belongs (
2b7b5d3 
pythonGH-112108)

(cherry picked from commit 0738b9a)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Dec 11, 2023
vstinner pushed a commit that referenced this pull request Dec 11, 2023
@miss-islington @sobolevn
[3.11] gh-108303: Move double_const to test_import where it belon…
70e50c0 
…gs (GH-112108) (#112977)

gh-108303: Move `double_const` to `test_import` where it belongs (GH-112108)
(cherry picked from commit 0738b9a)

Co-authored-by: Nikita Sobolev <[email protected]>
vstinner pushed a commit that referenced this pull request Dec 11, 2023
@miss-islington @sobolevn
[3.12] gh-108303: Move double_const to test_import where it belon…
ac8adf9 
…gs (GH-112108) (#112976)

gh-108303: Move `double_const` to `test_import` where it belongs (GH-112108)
(cherry picked from commit 0738b9a)

Co-authored-by: Nikita Sobolev <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @aisk
pythongh-108303: Move double_const to test_import where it belongs (
e2eb364 
python#112108)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @Glyphack
pythongh-108303: Move double_const to test_import where it belongs (
436b567 
python#112108)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@brettcannon brettcannon brettcannon left review comments
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @brettcannon @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.