GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108303: Delete `imp_dummy` test file by sobolevn · Pull Request #112110 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Nov 15, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This file was used in test_imp which was removed together with imp.py

  • Issue: Move test files into test subdirectories #108303

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-108303: Delete imp_dummy test file
b06e2f7
@sobolevn sobolevn added the skip news label Nov 15, 2023
@sobolevn
sobolevn requested a review from vstinner November 15, 2023 08:04
@bedevere-app bedevere-app Bot added the awaiting review label Nov 15, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Nov 15, 2023
Move test files into test subdirectories #108303
Closed
@vstinner
vstinner merged commit 422c0f0 into python:main Nov 15, 2023
@bedevere-app bedevere-app Bot removed the awaiting review label Nov 15, 2023
@vstinner vstinner added the needs backport to 3.12 only security fixes label Nov 15, 2023
@miss-islington-app

miss-islington-app Bot commented Nov 15, 2023

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 15, 2023
@sobolevn @miss-islington
pythongh-108303: Delete imp_dummy test file (pythonGH-112110)
1c67faf 
(cherry picked from commit 422c0f0)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app

bedevere-app Bot commented Nov 15, 2023

Copy link
Copy Markdown

GH-112114 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Nov 15, 2023
vstinner pushed a commit that referenced this pull request Nov 15, 2023
@miss-islington @sobolevn
[3.12] gh-108303: Delete imp_dummy test file (GH-112110) (#112114)
91a33fd 
gh-108303: Delete `imp_dummy` test file (GH-112110)
(cherry picked from commit 422c0f0)

Co-authored-by: Nikita Sobolev <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @aisk
pythongh-108303: Delete imp_dummy test file (python#112110)
9ffc8f9
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @Glyphack
pythongh-108303: Delete imp_dummy test file (python#112110)
21eee92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sobolevn @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.