GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112070: make `functools.lru_cache` threadsafe in --disable-gil build by wanderxjtu · Pull Request #112111 · python/cpython

Conversation

@wanderxjtu

@wanderxjtu wanderxjtu commented Nov 15, 2023 •
edited by colesbury
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #112070

  • Issue: Make functools.lru_cache thread-safe in --disable-gil builds #112070

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@wanderxjtu
wanderxjtu requested a review from rhettinger as a code owner November 15, 2023 10:37
@ghost

ghost commented Nov 15, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label Nov 15, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Nov 15, 2023
Make functools.lru_cache thread-safe in --disable-gil builds #112070
Closed
@bedevere-app

bedevere-app Bot commented Nov 15, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood changed the title gh-112070: make functools.lrucacle threadsafe in --disable-gil build gh-112070: make functools.lru_cache threadsafe in --disable-gil build Nov 15, 2023
@wanderxjtu
pythongh-112070: make functools.lrucacle threadsafe in --disable-gi…
f243dbd 
…l build
@wanderxjtu
wanderxjtu force-pushed the gh-112070-lrucache-nogil branch from cb84c37 to f243dbd Compare November 15, 2023 12:11
@bedevere-app

bedevere-app Bot commented Nov 15, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
wanderxjtu added 2 commits November 15, 2023 20:34
@wanderxjtu
pythongh-112070: update generate functoolsmodule files
3bddf43
@wanderxjtu
pythongh-112070: add NEWS file
9d75348
@wanderxjtu
wanderxjtu force-pushed the gh-112070-lrucache-nogil branch from daec45a to 9d75348 Compare November 15, 2023 12:34
@colesbury colesbury added topic-free-threading skip news labels Nov 15, 2023
colesbury
colesbury reviewed Nov 15, 2023
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wanderxjtu! I left a few comments inline. I don't think this change needs a NEWS entry, so I added the "skip news" label and removed the NEWS file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/_functoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_functoolsmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
colesbury and others added 2 commits November 15, 2023 18:10
@colesbury
Delete Misc/NEWS.d/next/Library/2023-11-15-20-19-45.gh-issue-112070.q…
e977bc4 
…6OhcU.rst
@wanderxjtu
pythongh-112070: reformat functoolsmodule.c
0fc873c
@colesbury
colesbury requested a review from corona10 November 16, 2023 16:22
colesbury
colesbury approved these changes Nov 16, 2023
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wanderxjtu!

@corona10, would you please review this PR?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Nov 16, 2023
@corona10

corona10 commented Nov 16, 2023

Copy link
Copy Markdown
Member

I will take a look
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 self-assigned this Nov 16, 2023
corona10
corona10 approved these changes Nov 17, 2023
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 17, 2023
@corona10
corona10 merged commit 0ee2d77 into python:main Nov 17, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 17, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@wanderxjtu @colesbury @aisk
pythongh-112070: make functools.lru_cache threadsafe in --disable-g…
d132795 
…il build (pythongh-112111)

* pythongh-112070: make `functools.lrucacle` threadsafe in --disable-gil build

* pythongh-112070: update generate `functoolsmodule` files

* pythongh-112070: add NEWS file

* Delete Misc/NEWS.d/next/Library/2023-11-15-20-19-45.gh-issue-112070.q6OhcU.rst

* pythongh-112070: reformat functoolsmodule.c

---------

Co-authored-by: Sam Gross <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@wanderxjtu @colesbury @Glyphack
pythongh-112070: make functools.lru_cache threadsafe in --disable-g…
3ab4905 
…il build (pythongh-112111)

* pythongh-112070: make `functools.lrucacle` threadsafe in --disable-gil build

* pythongh-112070: update generate `functoolsmodule` files

* pythongh-112070: add NEWS file

* Delete Misc/NEWS.d/next/Library/2023-11-15-20-19-45.gh-issue-112070.q6OhcU.rst

* pythongh-112070: reformat functoolsmodule.c

---------

Co-authored-by: Sam Gross <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@corona10 corona10 corona10 approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@corona10 corona10

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make functools.lru_cache thread-safe in --disable-gil builds

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@wanderxjtu @corona10 @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.