GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112137: change dis output to display labels instead of offsets by iritkatriel · Pull Request #112138 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Nov 16, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Change dis output to display labels instead of offsets #112137

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
iritkatriel added 2 commits November 15, 2023 22:08
@iritkatriel
Instruction gets the label
5470f75
@iritkatriel
replace offsets by labels
54cb8ca
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 16, 2023
@iritkatriel
iritkatriel marked this pull request as draft November 16, 2023 01:14
@bedevere-app bedevere-app Bot mentioned this pull request Nov 16, 2023
Change dis output to display labels instead of offsets #112137
Closed
2 tasks done
@bedevere-app bedevere-app Bot removed the awaiting core review label Nov 16, 2023
blurb-it Bot and others added 3 commits November 16, 2023 17:18
@blurb-it
📜🤖 Added by blurb_it.
c363ee8
@iritkatriel
Merge branch 'main' into dis_labels
6ac23fd
@iritkatriel
distinguish between jump targets (J) and exception handlers (H)
852c5c4
@iritkatriel
iritkatriel force-pushed the dis_labels branch from 31b2b72 to 852c5c4 Compare November 16, 2023 19:24
iritkatriel added 4 commits November 16, 2023 22:03
@iritkatriel
nice exception ranges
af97cee
@iritkatriel
labels in exception table, and on separate line in the code
d2884ed
@iritkatriel
fix tests
c527ded
@iritkatriel
do not collapse excaption table in tests
b3914e6
@iritkatriel
iritkatriel marked this pull request as ready for review November 17, 2023 18:02
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 17, 2023
@iritkatriel
iritkatriel requested a review from markshannon November 17, 2023 18:02
iritkatriel added 2 commits November 17, 2023 18:39
@iritkatriel
update dis.rst doctest
efd5906
@iritkatriel
whitespace
83ae74e
iritkatriel
iritkatriel commented Nov 20, 2023
View reviewed changes
Comment thread Lib/dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel and others added 10 commits November 20, 2023 10:28
@iritkatriel
whitespace
bac6628
@iritkatriel
add option to include offset and labels on same line as instruction
390c7a2
@iritkatriel
fix doctest
020c742
@iritkatriel
linenumber, then labels, then (optionally) offsets
965a3cd
@iritkatriel
update tests
7d00ddb
@iritkatriel
fix doctest
a7de18c
@iritkatriel
whitespace
cc24af8
@iritkatriel
whitespace
6542b06
@iritkatriel
add test with offsets
823b0e1
@iritkatriel
add doc
2219a96
iritkatriel added 2 commits November 22, 2023 17:09
@iritkatriel
whitespace
f52d698
@iritkatriel
whitespace
278aae3
iritkatriel
iritkatriel commented Nov 22, 2023
View reviewed changes
Comment thread Doc/library/dis.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
tweak doc
5420f6b
@iritkatriel
iritkatriel requested a review from brandtbucher November 22, 2023 20:43
iritkatriel
iritkatriel commented Nov 22, 2023
View reviewed changes
Comment thread Lib/dis.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
remove extra line
d741666
@iritkatriel
iritkatriel merged commit 10e1a0c into python:main Nov 22, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Nov 22, 2023
@iritkatriel
iritkatriel deleted the dis_labels branch November 28, 2023 12:45
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@iritkatriel @aisk
pythongh-112137: change dis output to display labels instead of offse…
06af3be 
…ts (python#112138)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@iritkatriel @Glyphack
pythongh-112137: change dis output to display labels instead of offse…
7cb4d69 
…ts (python#112138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon
@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.