GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-112088: Run autoreconf in GHA check_generated_files (GH-112090) by vstinner · Pull Request #112159 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Nov 16, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The "Check if generated files are up to date" job of GitHub Actions now runs the "autoreconf -ivf -Werror" command instead of the "make regen-configure" command to avoid depending on the external quay.io server.

Add Tools/build/regen-configure.sh script to regenerate the configure with an Ubuntu container image. The
"quay.io/tiran/cpython_autoconf:271" container image (https://github.com/tiran/cpython_autoconf) is no longer used.

(cherry picked from commit d9fd33a)

  • Issue: Consider avoiding the dependency on quay.io server in the GitHub Action "Check if generated files are up to date" job #112088

📚 Documentation preview 📚: https://cpython-previews--112159.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-112088: Run autoreconf in GHA check_generated_files (python#…
216b01c 
…112090)

The "Check if generated files are up to date" job of GitHub Actions
now runs the "autoreconf -ivf -Werror" command instead of the "make
regen-configure" command to avoid depending on the external quay.io
server.

Add Tools/build/regen-configure.sh script to regenerate the configure
with an Ubuntu container image. The
"quay.io/tiran/cpython_autoconf:271" container image
(https://github.com/tiran/cpython_autoconf) is no longer used.

(cherry picked from commit d9fd33a)
@vstinner
vstinner requested review from corona10, erlend-aasland, ezio-melotti and hugovk as code owners November 16, 2023 14:08
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 16, 2023
This was referenced Nov 16, 2023
Consider avoiding the dependency on quay.io server in the GitHub Action "Check if generated files are up to date" job #112088
Closed
gh-112088: Run autoreconf in GHA check_generated_files #112090
Merged
@bedevere-app bedevere-app Bot added the skip news label Nov 16, 2023
@vstinner vstinner mentioned this pull request Nov 16, 2023
[3.12] gh-112088: Run autoreconf in GHA check_generated_files (GH-112090) #112126
Closed
@vstinner

vstinner commented Nov 16, 2023

Copy link
Copy Markdown
Member Author

cc @hugovk @erlend-aasland
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk changed the title [3.12] gh-112088: Run autoreconf in GHA check_generated_files (#112090) [3.12] gh-112088: Run autoreconf in GHA check_generated_files (GH-112090) Nov 16, 2023
hugovk
hugovk approved these changes Nov 16, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 16, 2023
@vstinner
vstinner merged commit a498433 into python:3.12 Nov 16, 2023
@vstinner
vstinner deleted the avoid_quay_io12 branch November 16, 2023 14:55
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 16, 2023
@vstinner

vstinner commented Nov 16, 2023

Copy link
Copy Markdown
Member Author

Thanks for checking. Merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.