GeezerVison is showing github.com — Consider avoiding the dependency on quay.io server in the GitHub Action "Check if generated files are up to date" job · Issue #112088 · python/cpython
Consider avoiding the dependency on quay.io server in the GitHub Action "Check if generated files are up to date" job #112088DescriptionLast weeks/months, the quay.io server failed time time time. The problem is that the Python workflow has a GitHub Action "Check if generated files are up to date" job which pulls a container image from quay.io to run the make regen-configure command.
Should we consider avoiding the dependency on the quay.io server to make our workflow more reliable?
Linked PRs
Reacted by Erlend E. Aasland Activityvstinner commented on Nov 14, 2023 Recently, I documented commands to run make regen-configure with no container: https://docs.python.org/dev/using/configure.html#generated-files
I tried to run autoreconf -ivf -Werror in an Ubuntu 22.04 container (same Ubuntu version than the one currently used by the GHA job) to see if we can get the exact output. Sadly, it changes the output :-(
On Fedora, I create an Ubuntu 22.04 container with:
podman image pull ubuntu:22.04
podman image list --all
podman run --name ubuntu-dev --hostname ubuntu-dev --interactive --tty ubuntu:22.04
Commands which are supposed to produce the same output than make regen-configure:
apt update
apt install -y git autotools-dev autoconf autoconf-archive pkgconf
git clone https://github.com/python/cpython/ --depth=1
cd cpython/
autoreconf -ivf -Werror
git diff
Output:
diff --git a/aclocal.m4 b/aclocal.m4
index da8ee95..b309f4d 100644
--- a/aclocal.m4
+++ b/aclocal.m4
@@ -1,4 +1,4 @@
-# generated automatically by aclocal 1.16.4 -*- Autoconf -*-
+# generated automatically by aclocal 1.16.5 -*- Autoconf -*-
# Copyright (C) 1996-2021 Free Software Foundation, Inc.
Versions retrieved by dpkg -l|grep -E 'autotools|autoconf|pkgconf':
- autoconf 2.71-2
- autoconf-archive 20210219-2.1
- autotools-dev 20220109.1
- libpkgconf3:amd64 1.8.0-1
- pkgconf 1.8.0-1
vstinner commented on Nov 14, 2023 vstinner commented on Nov 14, 2023 vstinner commented on Nov 14, 2023 vstinner commented on Nov 14, 2023 The server fails with different errors:
podman run --rm --pull=always -v /home/runner/work/cpython/cpython:/src quay.io/tiran/cpython_autoconf:271
Trying to pull quay.io/tiran/cpython_autoconf:271...
Error: initializing source docker://quay.io/tiran/cpython_autoconf:271: can't talk to a V1 container registry
vstinner commented on Nov 14, 2023
apt install -y git autotools-dev autoconf autoconf-archive pkgconf
Hum, pkg-config should be installed, not pkgconf. vstinner commented on Nov 14, 2023
MetadataMetadataDevelopmentNo branches or pull requestsIssue actions
|