GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94309: py312 "what's new": improve deprecation notice for typing.Hashable and typing.Sized by salty-horse · Pull Request #112196 · python/cpython

Conversation

@salty-horse

@salty-horse salty-horse commented Nov 17, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The documentation of the deprecation of typing aliases in 3.12 (#94309) was just the names of the aliases, without a description of what happens to them. This can cause confusion, even if it's in the "Deprecated" section of documentation, since all other items include this description.

This should be backported to 3.12.

  • Issue: Deprecate typing.Hashable/Sized #94309

📚 Documentation preview 📚: https://cpython-previews--112196.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 17, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Nov 17, 2023
Deprecate typing.Hashable/Sized #94309
Closed
@AlexWaygood
AlexWaygood self-requested a review November 17, 2023 10:23
@AlexWaygood AlexWaygood added topic-typing needs backport to 3.12 only security fixes labels Nov 17, 2023
@AlexWaygood AlexWaygood changed the title gh-94309: Fix documentation for deprecated aliases gh-94309: py312 "what's new": improve deprecation notice for typing.Hashable and typing.Sized Nov 17, 2023
AlexWaygood
AlexWaygood reviewed Nov 17, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@salty-horse
pythongh-94309: Fix documentation for deprecated aliases
5a776e7
@salty-horse
salty-horse force-pushed the typing_deprecation_doc branch from 2f7fa98 to 5a776e7 Compare November 17, 2023 12:22
AlexWaygood
AlexWaygood approved these changes Nov 17, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
salty-horse reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 17, 2023
@AlexWaygood
AlexWaygood enabled auto-merge (squash) November 17, 2023 12:25
@AlexWaygood AlexWaygood self-assigned this Nov 17, 2023
@AlexWaygood
AlexWaygood merged commit fb4cddb into python:main Nov 17, 2023
@miss-islington-app

miss-islington-app Bot commented Nov 17, 2023

Copy link
Copy Markdown

Thanks @salty-horse for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 17, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 17, 2023
@salty-horse @miss-islington
pythongh-94309: "What's new in Python 3.12": improve deprecation noti…
4ebc12c 
…ce for typing.Hashable and typing.Sized (pythonGH-112196)

(cherry picked from commit fb4cddb)

Co-authored-by: Ori Avtalion <[email protected]>
@bedevere-app

bedevere-app Bot commented Nov 17, 2023

Copy link
Copy Markdown

GH-112200 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Nov 17, 2023
AlexWaygood pushed a commit that referenced this pull request Nov 17, 2023
@miss-islington @salty-horse
[3.12] gh-94309: "What's new in Python 3.12": improve deprecation not…
976488e 
…ice for typing.Hashable and typing.Sized (GH-112196) (#112200)

gh-94309: "What's new in Python 3.12": improve deprecation notice for typing.Hashable and typing.Sized (GH-112196)
(cherry picked from commit fb4cddb)

Co-authored-by: Ori Avtalion <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@salty-horse @aisk
pythongh-94309: "What's new in Python 3.12": improve deprecation noti…
74261c7 
…ce for typing.Hashable and typing.Sized (python#112196)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@salty-horse @Glyphack
pythongh-94309: "What's new in Python 3.12": improve deprecation noti…
fc6b30a 
…ce for typing.Hashable and typing.Sized (python#112196)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@AlexWaygood AlexWaygood

Labels

docs Documentation in the Doc dir skip news topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@salty-horse @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.