GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111926: Update _PyWeakref_IS_DEAD to be thread-safe by corona10 · Pull Request #112267 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Nov 19, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

see: #112250 (comment)

  • Issue: Make weakref thread-safe without the GIL #111926

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
pythongh-111926 Update _PyWeakref_IS_DEAD to be thread-safe
866af79
@corona10 corona10 added the topic-free-threading label Nov 19, 2023
@corona10
corona10 requested a review from colesbury November 19, 2023 12:59
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 19, 2023
@corona10 corona10 changed the title gh-111926 Update _PyWeakref_IS_DEAD to be thread-safe gh-111926: Update _PyWeakref_IS_DEAD to be thread-safe Nov 19, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Nov 19, 2023
Make weakref thread-safe without the GIL #111926
Closed
@corona10 corona10 added the skip news label Nov 19, 2023
corona10 added 2 commits November 19, 2023 22:00
@corona10
nit
01fb898
@corona10
lint
b0da60a
colesbury
colesbury approved these changes Nov 19, 2023
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good for now, but we'll need to come back to this again after other parts of weakrefobject.c are updated.

Py_REFCNT(obj) == 0 won't be sufficient here without the GIL. Outside of destructors, Py_REFCNT() is basically an estimate subject to race conditions. We'll want a check that ob_ref_shared == _Py_REF_MERGED, but we can't rely on that test either until we make some other changes to weakrefobject.c

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@corona10
corona10 merged commit 7c9f267 into python:main Nov 19, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Nov 19, 2023
@corona10
corona10 deleted the gh-111926-dead branch November 19, 2023 22:36
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@corona10 @aisk
pythongh-111926: Update _PyWeakref_IS_DEAD to be thread-safe (pythong…
a062334 
…h-112267)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@corona10 @Glyphack
pythongh-111926: Update _PyWeakref_IS_DEAD to be thread-safe (pythong…
8411ef8 
…h-112267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@corona10 @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.