GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-112243: Don't include comments in f-string debug expressions (GH-112284) by pablogsal · Pull Request #112285 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Nov 20, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

…

(cherry picked from commit d59feb5)

  • Issue: Decide how to handle comments with debug expressions in f-strings #112243

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
[3.12] pythongh-112243: Don't include comments in f-string debug expr…
de4f091 
…essions (pythonGH-112284)

(cherry picked from commit d59feb5)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@pablogsal
pablogsal requested a review from lysnikolaou as a code owner November 20, 2023 15:22
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 20, 2023
This was referenced Nov 20, 2023
Decide how to handle comments with debug expressions in f-strings #112243
Closed
gh-112243: Don't include comments in f-string debug expressions #112284
Merged
@pablogsal
pablogsal enabled auto-merge (squash) November 20, 2023 15:24
@pablogsal
pablogsal merged commit 7e70e2e into python:3.12 Nov 20, 2023
@pablogsal
pablogsal deleted the backport-d59feb5-3.12 branch November 20, 2023 15:38
@bedevere-app bedevere-app Bot removed the awaiting core review label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.