GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112243: Don't include comments in f-string debug expressions by pablogsal · Pull Request #112284 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Nov 20, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Decide how to handle comments with debug expressions in f-strings #112243

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pythongh-112243: Don't include comments in f-string debug expressions
f204fbd
@pablogsal
pablogsal requested a review from lysnikolaou as a code owner November 20, 2023 14:13
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 20, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Nov 20, 2023
Decide how to handle comments with debug expressions in f-strings #112243
Closed
lysnikolaou
lysnikolaou reviewed Nov 20, 2023
View reviewed changes

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments. Also, the lint job fails.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Parser/lexer/lexer.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Parser/lexer/lexer.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
fixup! pythongh-112243: Don't include comments in f-string debug expr…
2637415 
…essions
@pablogsal

pablogsal commented Nov 20, 2023

Copy link
Copy Markdown
Member Author

@lysnikolaou fixed!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lysnikolaou
lysnikolaou approved these changes Nov 20, 2023
View reviewed changes

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 20, 2023
@pablogsal
pablogsal merged commit d59feb5 into python:main Nov 20, 2023
@pablogsal
pablogsal deleted the fstrings_debug branch November 20, 2023 15:18
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 20, 2023
@bedevere-app

bedevere-app Bot commented Nov 20, 2023

Copy link
Copy Markdown

GH-112285 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal added a commit to pablogsal/cpython that referenced this pull request Nov 20, 2023
@pablogsal
[3.12] pythongh-112243: Don't include comments in f-string debug expr…
de4f091 
…essions (pythonGH-112284)

(cherry picked from commit d59feb5)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
pablogsal added a commit that referenced this pull request Nov 20, 2023
@pablogsal
[3.12] gh-112243: Don't include comments in f-string debug expressions (
7e70e2e 
GH-112284) (#112285)

(cherry picked from commit d59feb5)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@pablogsal @aisk
pythongh-112243: Don't include comments in f-string debug expressions (…
cd41ab6 
…python#112284)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@pablogsal @Glyphack
pythongh-112243: Don't include comments in f-string debug expressions (…
25649f7 
…python#112284)
@lysnikolaou lysnikolaou mentioned this pull request Jun 5, 2025
Parts of strings that look like comments being stripped out of nested strings with debug specifier #135148
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@pablogsal @lysnikolaou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.