GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111965: Use critical sections to make io.BufferedIOBase and its related classes thread safe by Mayuresh16 · Pull Request #112298 · python/cpython

Conversation

@Mayuresh16

@Mayuresh16 Mayuresh16 commented Nov 21, 2023 •
edited by colesbury
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

cc: @colesbury @corona10

  • Issue: Use critical sections to protect I/O objects (in --disable-gil builds) #111965

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Mayuresh16
bufferedio - Make buffered classes and getters functions thread safe …
87c4fe9 
…using critical sections
@ghost

ghost commented Nov 21, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Nov 21, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Nov 21, 2023
Use critical sections to protect I/O objects (in --disable-gil builds) #111965
Closed
@Mayuresh16

Mayuresh16 commented Nov 21, 2023

Copy link
Copy Markdown
Contributor Author

@colesbury Can you please review this draft PR once to help me to understand the issue if any exists in my work?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
colesbury
colesbury reviewed Nov 21, 2023
View reviewed changes

@colesbury colesbury left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks generally like a reasonable approach.

  • You will need to sign the CLA
  • You should make sure the build passes.

EDIT: Sorry - I see that you've already signed the CLA.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Mayuresh16 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@colesbury colesbury added skip news topic-IO topic-free-threading labels Nov 21, 2023
Mayuresh16 and others added 5 commits November 21, 2023 23:01
@Mayuresh16
move up the AC generated header before usage
e02a6bc
@Mayuresh16
correcting AC generated header line positioning and aligning inline h…
e437d49 
…eader comments
@Mayuresh16
Merge branch 'main' into bufferedio-critical-sections
1d3bdb8
@Mayuresh16
Merge branch 'python:main' into bufferedio-critical-sections
64372bb
@Mayuresh16
sync branch
6f7d9c7
@Mayuresh16

Mayuresh16 commented Nov 21, 2023

Copy link
Copy Markdown
Contributor Author
  • You should make sure the build passes.

Yeah, contributing for the first time so had a struggle bit but it was fun to begin and understand build checks too ;)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mayuresh16
Mayuresh16 requested a review from colesbury November 21, 2023 19:28
@Mayuresh16
Mayuresh16 marked this pull request as ready for review November 21, 2023 19:29
@bedevere-app bedevere-app Bot added the awaiting review label Nov 21, 2023
@colesbury
colesbury requested a review from corona10 November 22, 2023 01:21
colesbury
colesbury approved these changes Nov 22, 2023
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mayuresh16, this LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Mayuresh16 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Nov 22, 2023
@corona10 corona10 self-assigned this Nov 22, 2023
@corona10 corona10 mentioned this pull request Nov 22, 2023
Support getters and setters in Argument Clinic #112205
Closed
corona10
corona10 approved these changes Nov 22, 2023
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, In the end, we should support getter/setter from AC.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 22, 2023
@corona10
corona10 merged commit fef6fb8 into python:main Nov 22, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 22, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@Mayuresh16 @aisk
pythongh-111965: Use critical sections to make io.BufferedIOBase and …
5b9aa3a 
…its related classes thread safe (pythongh-112298)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@Mayuresh16 @Glyphack
pythongh-111965: Use critical sections to make io.BufferedIOBase and …
a345692 
…its related classes thread safe (pythongh-112298)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@corona10 corona10 corona10 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@corona10 corona10

Labels

skip news topic-free-threading topic-IO

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Mayuresh16 @colesbury @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.