GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112332: Deprecate TracebackException.exc_type, add exc_type_str. by iritkatriel · Pull Request #112333 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Nov 23, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #112332.

  • Issue: Deprecate TracebackException.exc_type  #112332

📚 Documentation preview 📚: https://cpython-previews--112333.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
iritkatriel added 3 commits November 23, 2023 09:58
@iritkatriel
pythongh-112332: save snapshot of exc_type in TracebackException. Add…
aad7828 
… option to not save the exc_type itself.
@iritkatriel
add depracation and doc
5aea01a
@iritkatriel
update tests
59fe163
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 23, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Nov 23, 2023
Deprecate TracebackException.exc_type #112332
Closed
@iritkatriel
iritkatriel requested a review from ericsnowcurrently November 23, 2023 10:38
@iritkatriel iritkatriel mentioned this pull request Nov 23, 2023
Support Passing a Proxy object to traceback.TracebackExcetion() for "exc_type" #111922
Closed
@iritkatriel
Add news
a278244
@iritkatriel iritkatriel added type-feature A feature request or enhancement stdlib Standard Library Python modules in the Lib/ directory 3.13 only security fixes labels Nov 23, 2023
@iritkatriel
add test for save_exc_type=False
6561596
ericsnowcurrently
ericsnowcurrently approved these changes Nov 28, 2023
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 28, 2023
@ericsnowcurrently

ericsnowcurrently commented Nov 28, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Thanks for doing this, @iritkatriel. I agree it's a better solution than what I had proposed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently ericsnowcurrently mentioned this pull request Nov 28, 2023
gh-111922: Allow Using a Minimal Proxy for TracebackException.exc_type #112324
Closed
@iritkatriel
iritkatriel merged commit 2c68011 into python:main Nov 28, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 28, 2023
@iritkatriel
iritkatriel deleted the traceback_exc_type branch November 28, 2023 12:45
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@iritkatriel @aisk
pythongh-112332: Deprecate TracebackException.exc_type, add exc_type_…
4289b72 
…str. (python#112333)
@davidism davidism mentioned this pull request May 11, 2024
test with python 3.13 pallets/werkzeug#2900
Merged
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@iritkatriel @Glyphack
pythongh-112332: Deprecate TracebackException.exc_type, add exc_type_…
98425f8 
…str. (python#112333)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.13 only security fixes stdlib Standard Library Python modules in the Lib/ directory type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate TracebackException.exc_type

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@iritkatriel @ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.