GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-106747: Improve `Path.glob()` expectations in pathlib tests by barneygale · Pull Request #112365 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Nov 24, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Add trailing slashes to expected Path.glob() results wherever a pattern has a trailing slash. This matches what glob.glob() produces.

Due to another bug (GH-65238) pathlib strips all trailing slashes, so this change is academic for now.

  • Issue: Glob behavior is inconsistent across libraries #106747

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barneygale
pythonGH-106747: Improve glob() expectations in pathlib tests
5ff4c47 
Add trailing slashes to expected `Path.glob()` results wherever a pattern
has a trailing slash. This matches what `glob.glob()` produces.

Due to another bug (pythonGH-65238) pathlib strips all trailing slashes, so this
change is academic for now.
@barneygale barneygale added tests Tests in the Lib/test dir skip news topic-pathlib labels Nov 24, 2023
@barneygale
barneygale requested a review from jaraco November 24, 2023 10:16
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 24, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Nov 24, 2023
Glob behavior is inconsistent across libraries #106747
Closed
@barneygale
Explicit value for current directory
72627e8
@barneygale barneygale mentioned this pull request Nov 25, 2023
[WIP] GH-65238: Preserve trailing slash in pathlib #112363
Closed
3 of 4 tasks
@barneygale
barneygale merged commit 09505c5 into python:main Dec 3, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Dec 3, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@barneygale @aisk
pythonGH-106747: Improve Path.glob() expectations in pathlib tests (p…
99e6252 
…ython#112365)

Add trailing slashes to expected `Path.glob()` results wherever a pattern
has a trailing slash. This matches what `glob.glob()` produces.

Due to another bug (pythonGH-65238) pathlib strips all trailing slashes, so this
change is academic for now.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@barneygale @Glyphack
pythonGH-106747: Improve Path.glob() expectations in pathlib tests (p…
acdaca7 
…ython#112365)

Add trailing slashes to expected `Path.glob()` results wherever a pattern
has a trailing slash. This matches what `glob.glob()` produces.

Due to another bug (pythonGH-65238) pathlib strips all trailing slashes, so this
change is academic for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco Awaiting requested review from jaraco

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@barneygale
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.