GeezerVison is showing github.com — gh-59013: Set breakpoint on the first executable line in pdb when using `break func` by gaogaotiantian · Pull Request #112470 · python/cpython
Conversation
gaogaotiantian
commented
Nov 27, 2023
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
In #110582, we made break foo work if foo is already a known function (that has an associated code object). However, if foo is in another module or it's not defined yet, we still use regular expression to find the definition, which will still set the breakpoint on the def line. This is an inconsistent behavior and will confuse users because the actual break will be on the first executable line.
This PR solves the issue by trying to compile the head of function to find the first executable line. As long as the first couple of lines are compilable, we should be able to find the first executable line of the function and set the break point on it. This skips comments, empty lines well (and not using pure strings to figure it out).
Notably, this is a breaking change - because the previous behavior is confusing.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
equationzhao and fjqz177 reacted with heart emoji
|
Hi @iritkatriel , do you have some time to take a look at this PR? Basically this tries to locate the first line of the function when the user break on a function that is not complied yet so the line number of the breakpoint would be correct.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|